Skip to content

[FEM.Elastic] Remove complex unproductive stiffness matrix data structure#6133

Open
alxbilger wants to merge 3 commits into
sofa-framework:masterfrom
alxbilger:removestiffness
Open

[FEM.Elastic] Remove complex unproductive stiffness matrix data structure#6133
alxbilger wants to merge 3 commits into
sofa-framework:masterfrom
alxbilger:removestiffness

Conversation

@alxbilger
Copy link
Copy Markdown
Contributor

@alxbilger alxbilger commented May 28, 2026

Since #6069, it is suspected that the ElementStiffnessMatrix data structure did not achieve its performance objectives. It was suggested to replace it by a simple matrix, and contain them in a vector.

This new PR applies the suggestion, and removes totally the complex data structure, that is no longer used.

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels May 28, 2026
@alxbilger alxbilger requested a review from fredroy May 28, 2026 12:41
@fredroy
Copy link
Copy Markdown
Contributor

fredroy commented May 29, 2026

@alxbilger did you run benchmarks on this branch vs master ?
I can do it on macOS and linux if you want. (to compare with #6069)

@fredroy
Copy link
Copy Markdown
Contributor

fredroy commented May 29, 2026

[ci-build][with-all-tests]

@alxbilger
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants