Bugfix/oo 50779 nui checkbox incorrect markup fix main#882
Draft
harsha573252 wants to merge 4 commits into
Draft
Bugfix/oo 50779 nui checkbox incorrect markup fix main#882harsha573252 wants to merge 4 commits into
harsha573252 wants to merge 4 commits into
Conversation
…d updated a11y rules Move the aria-checked attribute off the label and onto the native checkbox input to improve ARIA semantics (removed role="checkbox" and aria-checked from the label; added [attr.aria-checked] on the input). Update E2E accessibility specs by removing "aria-allowed-role" from the disabled rules arrays.
Replace attempts to toggle disabled checkboxes in e2e tests with assertions that the elements are disabled (packages/bits/e2e/components/checkbox-group/checkbox-group.e2e.spec.ts and packages/bits/e2e/components/checkbox/checkbox.e2e.spec.ts). Add a unit test in packages/bits/src/lib/checkbox/checkbox.component.spec.ts to ensure clicking a disabled checkbox does not change its checked state or emit valueChange. This prevents performing actions on disabled elements and verifies the component's disabled behavior.
Replace attempts to click disabled checkboxes with explicit assertions that the checkbox elements are disabled. This avoids interacting with controls that should be inactive and more accurately verifies that selection state remains unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend Pull Request Description:
A11y fix for nui-checkbox:
Move the aria-checked attribute off the label and onto the native checkbox input to improve ARIA semantics (removed role="checkbox" and aria-checked from the label; added [attr.aria-checked] on the input). Update E2E accessibility specs by removing "aria-allowed-role" from the disabled rules arrays.
Checklist
Screenshots (if applicable)
Additional Context (if necessary)