Skip to content

chore(size): batch re-record after #4714, #4711, #4717, #4719 and #4720 - #4718

Merged
ryansolid merged 5 commits into
nextfrom
claude/size-rerecord-17
Nov 8, 2026
Merged

ryansolid merged 5 commits into
nextfrom
claude/size-rerecord-17

Conversation

@ryansolid

@ryansolid ryansolid commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Size-Exception: the live page floor records +165 B minified (cap unchanged at 40.76 KB) and the renderToString floor records +13 B minified (cap unchanged at 22.92 KB). Both come from #4717 and #4720, whose growth and floor raises were accepted by the maintainer, plus #4719's lane-engine guard.

Summary

This is the one ledger re-record for the batch #4714, #4711, #4717, #4719 and #4720. It was measured locally over next @ 2789ca9 (with #4720), and it is the batch's only ledger PR.

scenario brotli minified change
app: isPending/latest 12,748 B 35,495 B cap unchanged at 12.76 KB; recorded minified +3 B
app: hydrating + every store primitive family 33,872 B 101,921 B cap 33.83 -> 33.89 KB; recorded minified +3 B
page: live server components (frozen) 40,734 B 123,070 B cap unchanged at 40.76 KB; recorded minified +165 B
page: live server components + router 50,580 B 148,802 B cap 50.57 -> 50.59 KB; recorded minified +3 B
server: renderToString (frozen) 22,903 B 77,888 B cap unchanged at 22.92 KB; recorded minified +13 B

Hello world (app: compiled floor) is 9,973 B against its 9,980 B cap, and the simple app is 9,792 B against 9,800 B.

Two rows are left as they are because their minified size went down. They pass with a warning, and only their brotli layout moved:

  • page: compiled base server components is 36 B over its 36.00 KB cap, at −46 B minified.
  • page: compiled live server components is 44,833 B against a 44.85 KB cap, at −11 B minified.

How did you test this change?

  • node size.mjs --json over next @ 2789ca9.
  • npm test in scripts/size.

🤖 Generated with Claude Code

https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

Live page floor 40.66 -> 40.71 KB (minified unchanged; #4717 measured
without #4714). Compiled live recorded minified +2 B, renderToString +13 B.
Measured over next @ 46a72c0, matching size job 128670072096.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE
@changeset-bot

changeset-bot Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 303d4f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.42 KB 0 B 0 B −136 B 7.43 KB ✅
signals: + createStore 15.11 KB 0 B 0 B −21 B 15.13 KB ✅
signals: + isPending/latest 12.75 KB 0 B 0 B 0 B 12.76 KB ✅
signals: + until/refresh (truth readers, no optimism) 8.10 KB 0 B 0 B −21 B 8.12 KB ✅
app: render + one signal (the simple-app floor) 9.79 KB 0 B 0 B −195 B 9.80 KB ✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 19.05 KB 0 B 0 B −45 B 19.05 KB ✅ lazy-page.js 0.04 KB
app: hydrating + every store primitive family 33.87 KB 0 B 0 B 0 B 33.89 KB ✅ lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.73 KB 0 B 0 B −45 B 13.73 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.45 KB 0 B 0 B −45 B 15.50 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 30.08 KB 0 B 0 B −45 B 30.12 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 9.97 KB 0 B 0 B −247 B 9.98 KB ✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.73 KB 0 B 0 B −35 B 26.75 KB ✅ stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 32.92 KB 0 B 0 B −35 B 33.00 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.75 KB 0 B 0 B 0 B 11.77 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 34.09 KB 0 B 0 B −32 B 34.11 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.28 KB, wire.js 3.48 KB
page: live server components (base + live/GET + action + isPending/latest) 40.73 KB 0 B 0 B 0 B 40.76 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.29 KB, wire.js 3.48 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 36.04 KB 0 B 0 B −46 B 36.00 KB ⚠️ over by 36 B, 66 B minified headroom assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.29 KB, wire.js 3.48 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 44.83 KB 0 B 0 B −11 B 44.85 KB ✅ eager (counted): web.js 23.67 KB; assets.js 0.78 KB, decode.js 7.09 KB, regions.js 1.08 KB, sc-comments.js 0.19 KB, trace.js 9.28 KB, wire.js 3.48 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 41.56 KB 0 B 0 B −120 B 41.60 KB ✅ assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.58 KB, trace.js 9.25 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 50.58 KB 0 B 0 B 0 B 50.59 KB ✅ eager (counted): client.js 28.84 KB; assets.js 0.78 KB, decode.js 7.09 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.03 KB, serverForms.js 3.31 KB, trace.js 9.27 KB, wire.js 3.50 KB
server: floor (getRequestEvent + isServer) 1.27 KB 0 B 0 B 0 B 1.29 KB ✅
server: renderToString (the server-render floor) 22.90 KB 0 B 0 B 0 B 22.92 KB ✅

⚠️ Over the brotli cap within the minified allowance (passes)

  • page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread): over brotli cap by 36 B; minified 108,500 B vs 108,546 B recorded with the cap (−46 B) — 66 B of the 20 B minified allowance left; +0 B minified over this PR's base

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@coveralls

coveralls commented Nov 8, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 42464228996

Warning

No base build found for commit 9c66532 on next.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 78.945%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 1372
Covered Lines: 1143
Line Coverage: 83.31%
Relevant Branches: 1112
Covered Branches: 818
Branch Coverage: 73.56%
Branches in Coverage %: Yes
Coverage Strength: 30.18 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Nov 8, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 8.43%

2 warnings

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

❌ 1 regressed benchmark
✅ 200 untouched benchmarks
⏩ 5 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ arrow in template 10.9 ms 11.9 ms -8.43%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/size-rerecord-17 (3b73548) with next (46a72c0)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copy link
Copy Markdown
Member Author

The CodSpeed row (non-ascii-template: arrow in template, -8.4%) isn't this PR's. The diff only touches scripts/size/scenarios.js comments and numbers and scripts/size/floor-caps.json, none of which a benchmark imports. That same bench has swung ±5–13% on unrelated heads over the last few days, with its ascii only twin moving the opposite way.


Generated by Claude Code

Live page floor 40.68 KB (122,849 B), compiled live 44.79 KB (131,098 B),
measured over next @ 9c66532.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE
@ryansolid ryansolid changed the title chore(size): batch re-record after #4714, #4711 and #4717 chore(size): batch re-record after #4714, #4711, #4717 and #4719 Nov 8, 2026

Copy link
Copy Markdown
Member Author

The four red Run benchmarks (…) jobs on af77f9a never reached a benchmark. The CodSpeed action's CLI install step fails while downloading the CLI (Installation of CodSpeed CLI with version 4.19.1 failed. Reason: HTTP 504 - Gateway Time-out) about 11 s in. It failed the same way on one re-run. This is CodSpeed's download host, not this diff: the PR only touches scripts/size/ ledger values, which no benchmark loads. There's no fix to port. The jobs need another run once that host is responding.


Generated by Claude Code

@ryansolid ryansolid changed the title chore(size): batch re-record after #4714, #4711, #4717 and #4719 chore(size): batch re-record after #4714, #4711, #4717, #4719 and #4720 Nov 8, 2026
Folds #4720's cap raises into this batch's single ledger re-record,
measured locally over next @ 2789ca9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

Copy link
Copy Markdown
Member Author

The job check failed twice on 5a34ea3, both times on the Coveralls reporter install step. The test steps passed first.

  • First attempt: the reporter tarball failed its checksum. Expected cd042b63…, got bef140a1….
  • Re-run: the checksum download returned 504 Gateway Time-out.

Both failures are in the coverage upload's infrastructure, not anything this PR changes. This PR only touches scripts/size ledger values, and the size gate and tests are green. No fix exists on our side. It clears once Coveralls serves the reporter again.


Generated by Claude Code

@ryansolid
ryansolid merged commit dbd746b into next Nov 8, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants