Repository navigation
Strip expected directory prefix with substr - #6
Merged
Merged
Conversation
PHPStan reported:
src/AssertDirectory.php:55
Parameter #1 $separator of function explode expects non-empty-string, string given.
Splitting on $expected was an indirect way to cut the prefix off the
iterated pathname. Since $expected is always that prefix, substr says
so directly and drops the non-empty-string requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master is red because a recent PHPStan release tightened the signature of explode: https://github.com/spawnia/phpunit-assert-directory/actions/runs/33604583891
Splitting the iterated pathname on $expected was an indirect way to cut the prefix off it. $expected is always that prefix — every pathname comes from iterating it — so substr expresses the intent directly and needs no non-empty-string guarantee.