fix: install STM32RTC from Github#590
Merged
noisymime merged 1 commit intospeeduino:masterfrom Jun 7, 2021
Merged
Conversation
Signed-off-by: wilmardo <info@wilmardenouden.nl>
Contributor
Author
|
Followup issue on the PIO side: |
Collaborator
|
Nice work investigating this. I had gotten as far as discovering something was broken on the RTC library, but not dug any deeper. |
VitorBoss
pushed a commit
to VitorBoss/speeduino
that referenced
this pull request
Jun 9, 2021
Signed-off-by: wilmardo <info@wilmardenouden.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the build on the latest
ststm32platform. With release of the platform 2.0.0 it moved some RTC files from the core to theSTM32RTClibrary.Platform side:
stm32duino/Arduino_Core_STM32#1110
Library side:
stm32duino/STM32RTC@bf74a2c
But the library is wrongly tagged in the PlatformIO library manager, the latest release is 1.1.0 of May 2020. Since that release is missing the moved core files it breaks the build.
I opened an issue to fix it but the maintainer isn't that keen to look into it:
stm32duino/STM32RTC#49
I will followup on the issue on the PIO side but for now this will fix the build.