Skip to content

Support logical predicates in HqlOrderExpressionVisitor - #4426

Closed
AdzerKI wants to merge 1 commit into
spring-projects:mainfrom
AdzerKI:gh-4425
Closed

AdzerKI wants to merge 1 commit into
spring-projects:mainfrom
AdzerKI:gh-4425

Conversation

@AdzerKI

@AdzerKI AdzerKI commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Adds and, or, not and grouped predicates to HqlOrderExpressionVisitor, so a CASE WHEN condition in JpaSort.unsafe(…) keeps all its operands. The test covers each of them.

Closes #4425

Translate and, or, not and grouped predicates so CASE WHEN conditions of JpaSort.unsafe(…) keep all their operands.

Closes spring-projects#4425

Signed-off-by: AdzerKI <silver_cat@list.ru>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 11, 2026
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 12, 2026
@mp911de mp911de self-assigned this Nov 12, 2026
@mp911de mp911de added this to the 4.0.9 (2025.1.9) milestone Nov 12, 2026
mp911de pushed a commit that referenced this pull request Nov 12, 2026
Translate and, or, not and grouped predicates so e.g. CASE WHEN conditions of JpaSort.unsafe(…) keep all their operands.

Closes #4425
Original pull request: #4426

Signed-off-by: AdzerKI <silver_cat@list.ru>
mp911de added a commit that referenced this pull request Nov 12, 2026
Reformat code, add ticket reference and author tag to tests.

See #4425
Original pull request: #4426
mp911de pushed a commit that referenced this pull request Nov 12, 2026
Translate and, or, not and grouped predicates so e.g. CASE WHEN conditions of JpaSort.unsafe(…) keep all their operands.

Closes #4425
Original pull request: #4426

Signed-off-by: AdzerKI <silver_cat@list.ru>
mp911de added a commit that referenced this pull request Nov 12, 2026
Reformat code, add ticket reference and author tag to tests.

See #4425
Original pull request: #4426
mp911de pushed a commit that referenced this pull request Nov 12, 2026
Translate and, or, not and grouped predicates so e.g. CASE WHEN conditions of JpaSort.unsafe(…) keep all their operands.

Closes #4425
Original pull request: #4426

Signed-off-by: AdzerKI <silver_cat@list.ru>
mp911de added a commit that referenced this pull request Nov 12, 2026
Reformat code, add ticket reference and author tag to tests.

See #4425
Original pull request: #4426
@mp911de

mp911de commented Nov 12, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JpaSort.unsafe drops and/or operands of a CASE WHEN condition

3 participants