Strip psql meta-commands from schema files (fixes #4065)#4390
Merged
kyleconroy merged 1 commit intomainfrom Apr 19, 2026
Merged
Strip psql meta-commands from schema files (fixes #4065)#4390kyleconroy merged 1 commit intomainfrom
kyleconroy merged 1 commit intomainfrom
Conversation
pg_dump 17.6+ (backported to 13.22, 14.19, 15.14, 16.10) emits \restrict/\unrestrict meta-commands that are valid psql syntax but not valid SQL, causing sqlc to fail when parsing schema.sql from pg_dump. Add a regex-based preprocessor in the migrations package that strips any line starting with a psql meta-command (\<command>), and call it from parseCatalog after RemoveRollbackStatements. Extend the pg_dump end-to-end schema fixture with \restrict/\unrestrict lines so TestReplay exercises this path.
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_dump 17.6+ (backported to 13.22, 14.19, 15.14, 16.10) emits
\restrict/\unrestrict meta-commands that are valid psql syntax but not
valid SQL, causing sqlc to fail when parsing schema.sql from pg_dump.
Add a regex-based preprocessor in the migrations package that strips
any line starting with a psql meta-command (<command>), and call it
from parseCatalog after RemoveRollbackStatements. Extend the pg_dump
end-to-end schema fixture with \restrict/\unrestrict lines so TestReplay
exercises this path.