docs(hotfix): document orphan self-heal, correct stale reserved-shape comments, add callbacks matrix row#425
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
…e row Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Final part of #411. Three code-verified items:
Hotfix orphan self-heal docs (workflows.md): a "Reconciling a stale env branch" subsection documenting that the plan reconciles env/ against the recorded state SHA (absent -> create; matching -> untouched; drifted -> self-heal or fail-closed), that an interrupted run's orphan tip is force-reset to the recorded SHA, and the two-condition gate: reset fires ONLY when the env is not diverged AND the single-flight check (via --repo owner/repo) found no open hotfix PR matching either the cascade-hotfix or cascade-hotfix-conflict label. Notes --dry-run plans-but-does-not-reset, and that without --repo the self-heal cannot fire. Verified against internal/hotfix chain.go/plan.go/command.go/lifecycle.go.
Corrected stale reserved-shape comments in internal/config/types.go, per-field verified against the generator:
coverage-matrix.md: added the missing Topologies row for cascade-example-callbacks (the 11th fleet repo the tip already counts), mapped to the existing act scenarios orchestrate/secrets-opt-in and orchestrate/callback-permissions-oidc.
Verification
go build clean; go vet ./internal/config clean (types.go change is comment-only); markdown well-formed; guardrails clean.
Maintainer note (out of scope, flagging): coverage-matrix's "Last validated" tip still says v0.5.1.