feat(demo): add synthetic CloudTrail IAM investigation#58
Conversation
12ef032 to
76133bf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12ef032a13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ["CreateAccessKey", "AttachUserPolicy", "AttachRolePolicy"], | ||
| ) | ||
| ) | ||
| disable_events = {"StopLogging", "DeleteTrail", "UpdateTrail"} |
There was a problem hiding this comment.
Don't treat every UpdateTrail as logging disabled
When a synthetic sample contains a successful CloudTrail UpdateTrail near an IAM change, this rule emits cloudtrail_logging_disabled_near_iam_change even though UpdateTrail is a general trail update and does not by itself stop or delete logging; that produces a critical disabled-logging signal for benign trail edits. Limit this set to actions that actually disable/remove logging, or inspect the UpdateTrail parameters before classifying it this way.
Useful? React with 👍 / 👎.
Summary
Validation
Boundaries