Repository navigation
fix: track the finger directly when inspecting charts on touch - #237
Merged
Merged
Conversation
Inspection marks glided to each sample on springs, and the line chart tooltip trailed on a softer follow spring. Under a finger that read as lag. During a touch drag the line chart crosshair, dots, axis pill, receding mask and tooltip, the bar chart band and the sparkline dot now track the touch directly; mouse and keyboard keep the glide.
The crosshair glided between columns on a layout spring, which trailed a touch drag. It now jumps to the column under the finger during a touch drag; mouse and keyboard keep the glide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On touch screens, chart inspection marks now follow the finger directly instead of gliding behind it.
Mouse and keyboard keep the glide, and data-change springs are untouched.
Why
Every inspection mark moved to the inspected sample on a spring. With a mouse that reads as smooth, but under a finger any glide reads as lag. This was reported on mobile for the line chart.
How
xyinspector reports when a touch drag starts and ends (onTouchChange), anduseInspectionholds atouchingflag.Other charts checked
Verification
bun run checkpasses, andbun testpasses 190 accessibility tests.updatedAtis bumped and it has a changelog line. Line, Bar and Sparkline are still this week's new entries.