Repository navigation
fix(workflow): stop commands in builder output - #41
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A line that
builderprinted incheck,prepare,verifyorpublishcould reach the runner as a workflow command.git cloneingit-latestprints theERRpacket of a git server line by line, so the server can put::add-mask::trueon a line of its own. The runner then skips the outputsprepareandworkofcheck, and no update runs while the job stays green. The prefix thatPrepare updatesput on every line did not stop##[add-mask]true, which the runner reads anywhere in a line.The four steps that run
check-all.shnow print::stop-commands::with a random token before it and::<token>::after it, and pipe its output throughcat, so nothingbuilderprints comes after the token.bats tests/ --recursive: 419 pass,actionlintis clean.