Skip to content

fix(workflow): stop commands in builder output - #41

Merged
noctuum merged 1 commit into
mainfrom
fix/stop-workflow-commands
Oct 16, 2026
Merged

noctuum merged 1 commit into
mainfrom
fix/stop-workflow-commands

Conversation

@noctuum

@noctuum noctuum commented Oct 16, 2026

Copy link
Copy Markdown
Member

A line that builder printed in check, prepare, verify or publish could reach the runner as a workflow command. git clone in git-latest prints the ERR packet of a git server line by line, so the server can put ::add-mask::true on a line of its own. The runner then skips the outputs prepare and work of check, and no update runs while the job stays green. The prefix that Prepare updates put on every line did not stop ##[add-mask]true, which the runner reads anywhere in a line.

The four steps that run check-all.sh now print ::stop-commands:: with a random token before it and ::<token>:: after it, and pipe its output through cat, so nothing builder prints comes after the token.

bats tests/ --recursive: 419 pass, actionlint is clean.

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@noctuum
noctuum merged commit 1d4fa37 into main Oct 16, 2026
5 checks passed
@noctuum
noctuum deleted the fix/stop-workflow-commands branch October 16, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant