Fix DAC for F103RF and RG#1040
Merged
fpistm merged 2 commits intostm32duino:masterfrom Apr 21, 2020
Merged
Conversation
Implementation is located in PeripheralPins.c
Member
|
The define have to be in the variant |
Contributor
Author
|
There's an ifdef here: Arduino_Core_STM32/variants/Generic_F103Rx/PeripheralPins.c Lines 89 to 97 in 6eaa8d2 But this means we'll have to manually have to enable |
Member
|
ADC is defined by default for all as all have an ADC. |
fpistm
requested changes
Apr 21, 2020
fpistm
approved these changes
Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These lines prevented the DAC implementation from working on F103RF and F103RG.
Note that the definition is located in PeripheralPins.c.