[RUMBA32] Minor Improvements and Fixes

[chrissbarr]

[RUMBA32] Minor Improvements and Fixes

Summary

The fixes relating to timer conflicts are raised as a result of the investigation conducted here: Aus3D/RUMBA32#26

This PR fixes/implements the following changes:

• Update PWM pin mapping
  • Remove timer conflicts (refer to Fan PWM Troubleshooting / Timer Investigation Aus3D/RUMBA32#26)
  • Enable PWM on pins in EXP3 header (refer to PWM for Bltouch and LEDs on AUX pins? Aus3D/RUMBA32#8)
  • breaking change - PWM is removed from some pins it was available on previously. However, the RUMBA32 board could not take advantage of PWM on those pins / no reason to use PWM on those pins. Further, some of these PWM pin timer mappings were in conflict with other PWM pins - so it is likely that they would not have worked correctly if actually used.
• Set TIMER_SERIAL to TIM9 to remove conflict with TIMER_SERVO (refer to Variant.h for RUMBA32 #731 and Fan PWM Troubleshooting / Timer Investigation Aus3D/RUMBA32#26)
  • Check if TIMER pin mapping can be overridden by user
• Enable ADC mapping on all pins which map to ADC1 (original A0 - A6 pin mapping is preserved and there should be no impact to existing software that uses those pin names)
• Enable UART5 on EXP1 header
• Tidy variant files and add peripheral options from current genpinmap file (a few additional UART, SPI etc. options are in the current file, added)

I am curious, does anyone know if there's a way to define the timers in the variant.h file such that they can be overridden by the user's code? For instance, I tried setting up the variant.h file like:

#ifndef TIMER_SERIAL
  #define TIMER_SERIAL           TIM9
#endif

But it seems that the variant.h file gets compiled before anything I do in the Arduino sketch / header, and I see a warning that TIMER_SERIAL is redefined. Is there a way to make this work? Would be quite useful if the TONE, SERVO and SERIAL timers could all be redefined by the user, while still allowing for a variant default.

Validation

• Ensure CI build is passed.
• Demonstrate the code is solid. [e.g. Provide a sketch]

Code formatting

• Ensure AStyle check is passed thanks CI

Closing issues

[fpistm]

I am curious, does anyone know if there's a way to define the timers in the variant.h file such that they can be overridden by the user's code? For instance, I tried setting up the variant.h file like:

#ifndef TIMER_SERIAL
  #define TIMER_SERIAL           TIM9
#endif

But it seems that the variant.h file gets compiled before anything I do in the Arduino sketch / header, and I see a warning that TIMER_SERIAL is redefined. Is there a way to make this work? Would be quite useful if the TONE, SERVO and SERIAL timers could all be redefined by the user, while still allowing for a variant default.

Well, in this case you could redefine it at the sketch level, using the build_opt.h with:
-DTIMER_SERIAL=TIM9

https://github.com/stm32duino/wiki/wiki/Customize-build-options-using-build_opt.h

[chrissbarr]

Well, in this case you could redefine it at the sketch level, using the build_opt.h with:
-DTIMER_SERIAL=TIM9

Hmm, it might be worth surrounding each of the timers defined in variant.h with an #ifndef check then, so that they can be overridden in this way if desired. Are you aware of any disadvantages to doing this? If not, I think I'll add a commit doing this for serial/servo/tone timers.

[fpistm]

Hmm, it might be worth surrounding each of the timers defined in variant.h with an #ifndef check then, so that they can be overridden in this way if desired. Are you aware of any disadvantages to doing this? If not, I think I'll add a commit doing this for serial/servo/tone timers.

From my point of view there is no issue to add #ifndef.

[fpistm]

LGTM.

[chrissbarr]

Thanks @fpistm. I've noticed a bit of weirdness when using SoftwareSerial with certain pins, and have opened an issue about this (#1093). Hope you can take a look when you get the opportunity.

I might hold off on requesting a merge on this until I understand what's happening there, in case it's something I've introduced or can fix in the pin definitions.

[chrissbarr]

All right, I'm satisfied with these changes and am happy for the PR to be merged. I'll move it from draft now and it is yours to review @fpistm!

[fpistm]

LGTM