HardwareTimer: pause() need to call HAL API to restore HAL state#1166
Merged
fpistm merged 1 commit intostm32duino:masterfrom Sep 9, 2020
Merged
Conversation
ABOSTM
force-pushed
the
HARDWARETIMER_PAUSE_RESTORE_STATE
branch
from
2a1ff77 to
9f15ada
Compare
Contributor
Author
|
Tested on L476RG |
Due to HAL Cube update (ex: for STM32L4 sha1 f41f10e) it is now required to stop timer with HAL API otherwise HAL state is not restored to HAL_TIM_STATE_READY, and it is not possible to resume() a HardwareTimer after a pause(). Nevertheless it is not sufficient to guarantee that timer is stopped specially if some channels are still running. So it is also necessary to keep also the call to LL_TIM_DisableCounter() Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
ABOSTM
force-pushed
the
HARDWARETIMER_PAUSE_RESTORE_STATE
branch
from
9f15ada to
f809e54
Compare
fpistm
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HardwareTimer: pause() need to call HAL API to restore HAL state
Due to HAL Cube update (ex: for STM32L4 sha1 f41f10e)
it is now required to stop timer with HAL API
otherwise HAL state is not restored to HAL_TIM_STATE_READY,
and it is not possible to
resume()a HardwareTimer after apause().Nevertheless it is not sufficient to guarantee that timer is stopped.
specially if some channels are still running.
So it is also necessary to keep also the call to LL_TIM_DisableCounter()