Daisy Seed - added missing ram section to linker#1265
Merged
fpistm merged 1 commit intostm32duino:masterfrom Jan 23, 2021
Merged
Daisy Seed - added missing ram section to linker#1265fpistm merged 1 commit intostm32duino:masterfrom
fpistm merged 1 commit intostm32duino:masterfrom
Conversation
fpistm
approved these changes
Jan 23, 2021
Member
fpistm
left a comment
fpistm
left a comment
There was a problem hiding this comment.
Hi @stephenhensley
I guess you have tested and use it so LGTM.
Author
|
Hi @fpistm thanks! Yeah, tests okay on our end. It was actually an oversight to not include it in the first place. Our audio library uses that section for DMA buffers, and without this it required us to disable the dcache (which on the h7 is a pretty hefty performance hit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
Adding this provides a memory section that can be used for DMA buffers, and other non-cacheable data so that DCache can be enabled without requiring maintenance.