Skip to content

SoftwareSerial stopListening at the begining#1269

Merged
fpistm merged 1 commit intostm32duino:masterfrom
FRASTM:SoftSerial
Jan 4, 2021
Merged

SoftwareSerial stopListening at the begining#1269
fpistm merged 1 commit intostm32duino:masterfrom
FRASTM:SoftSerial

Conversation

@FRASTM
Copy link
Copy Markdown
Contributor

@FRASTM FRASTM commented Dec 22, 2020

When begining the transaction, in the SoftwareSerial::begin
, the active_listener is not yet assigned, but null.
Then it differs from this but should not act as if it was listening.

This is the case when testing on nucleo_l552ze board.

Signed-off-by: Francois Ramu francois.ramu@st.com

@fpistm fpistm requested review from ABOSTM and fpistm December 22, 2020 09:16
Comment thread libraries/SoftwareSerial/src/SoftwareSerial.cpp Outdated
When begining the transaction, the active_listener is not yet
assigned, but null. Then it differs from this but should not
act as if it was listening.
This is the case when testing on nucleo_l552ze board.

Signed-off-by: Francois Ramu <francois.ramu@st.com>
@fpistm fpistm added the fix 🩹 Bug fix label Dec 22, 2020
@fpistm fpistm added this to the 2.0.0 milestone Dec 22, 2020
Copy link
Copy Markdown
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit f4c200f into stm32duino:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 🩹 Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants