library: Wire/SPI: change default pins type#1438
Merged
fpistm merged 2 commits intostm32duino:masterfrom Jul 6, 2021
Merged
Conversation
This allows _ALTx pins usage. Fixes stm32duino#1432 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
This allows _ALTx pins usage. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
_ALTxintroduction, default Arduino API usinguint8_ttype for pin number could not use them and raised raised this error:Moving API to uint32_t allows to use
_ALTx, anyway some libraries used the default pin definition as an uint8_t from the variant definition, for example:Which is stored in:
With Arduino SD library:
https://github.com/arduino-libraries/SD/blob/a64c2bd907460dd01cef07fff003550cfcae0119/src/utility/Sd2Card.h#L75-L83
In this case this is not risky as those conversion will use the correct pin for SOFTWARE_SPI (GPIO toggling) not related to a peripheral and in major way default pins uses value without
_ALTxwhich mean an unit8_t size and so does not raised warning.Anyway not all libraries could use
_ALTxfeature.Fixes #1432