chore: update SPI pins for Swan_R5#1489
Merged
fpistm merged 1 commit intostm32duino:masterfrom Sep 8, 2021
Merged
Conversation
Member
|
Hi @zfields , Note that it is not a bug 😉 |
Contributor
Author
|
Oh, no! I must have felt handcuffed by your PR template. 😄 No worries though! I actually labelled it as a "chore" in the real commit message, because I didn't really see it as a bug either. 👍 Long story short, our out of the box configuration exposes the STM32L4xx pins I specified via the Adafruit Feather pinout. I was working from the board schematic and an oscilloscope in order to make the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update SPI pins (MOSI, MISO, SCK, SS) for Swan_R5
This PR fixes/implements the following bugs/features
[Bug] SPI does not trigger the appropriate pins.
I work at Blues Wireless. During preparation and testing of the Swan, I discovered the SPI pins were not functional through the Feather pinouts.
Validation
Code formatting
It's all in the preprocessor, and it was copied from the existing pattern.
Closing issues