Skip to content

chore: update SPI pins for Swan_R5#1489

Merged
fpistm merged 1 commit intostm32duino:masterfrom
zfields:swan-spi
Sep 8, 2021
Merged

chore: update SPI pins for Swan_R5#1489
fpistm merged 1 commit intostm32duino:masterfrom
zfields:swan-spi

Conversation

@zfields
Copy link
Copy Markdown
Contributor

@zfields zfields commented Sep 8, 2021

Summary

update SPI pins (MOSI, MISO, SCK, SS) for Swan_R5

This PR fixes/implements the following bugs/features

[Bug] SPI does not trigger the appropriate pins.

I work at Blues Wireless. During preparation and testing of the Swan, I discovered the SPI pins were not functional through the Feather pinouts.

Validation

  • I have used the code to drive an MCP23S17 from the Swan.

Code formatting

It's all in the preprocessor, and it was copied from the existing pattern.

Closing issues

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Sep 8, 2021

Hi @zfields ,
In fact default SPI instance pins were defined to use PA5/PA6/PA7 by default using SPI peripheral.
So with your change it will use SPI2 peripheral with the pins you defined.
If it is what you want by default, it is OK.

Note that it is not a bug 😉

@fpistm fpistm added the enhancement New feature or request label Sep 8, 2021
@fpistm fpistm added this to the 2.1.0 milestone Sep 8, 2021
@zfields
Copy link
Copy Markdown
Contributor Author

zfields commented Sep 8, 2021

Oh, no! I must have felt handcuffed by your PR template. 😄 No worries though! I actually labelled it as a "chore" in the real commit message, because I didn't really see it as a bug either. 👍

Long story short, our out of the box configuration exposes the STM32L4xx pins I specified via the Adafruit Feather pinout. I was working from the board schematic and an oscilloscope in order to make the change.

Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit ecd67a9 into stm32duino:master Sep 8, 2021
@zfields zfields deleted the swan-spi branch September 8, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants