Skip to content

Added Elektor LoRa Node ( STM32F072 based )#810

Merged
fpistm merged 18 commits intostm32duino:masterfrom
lab-mathias-claussen:master
Dec 3, 2019
Merged

Added Elektor LoRa Node ( STM32F072 based )#810
fpistm merged 18 commits intostm32duino:masterfrom
lab-mathias-claussen:master

Conversation

@lab-mathias-claussen
Copy link
Copy Markdown
Contributor

@lab-mathias-claussen lab-mathias-claussen commented Dec 2, 2019 •
edited by fpistm
Loading

This adds board support for Elektor LoRa Node with STM32F072 MCU

Added Elektor LoRa Node ( STM32F072 based )
d72879d 
This adds board support for Elektor LoRa Node with STM32F072 MCU
@fpistm fpistm added the new variant Add support of new bard label Dec 2, 2019
@fpistm
Copy link
Copy Markdown
Member

fpistm commented Dec 2, 2019

Hi @lab-mathias-claussen
thanks for this PR.
Please, could you add it under "Lora Boards" menu instead of create new item menu.
Could you provide a link the the board description (User manual, schematics,...)?
Thanks

Moved board to LoRa section
217e5dc 
Board is now within the LoRa section
@lab-mathias-claussen
Copy link
Copy Markdown
Contributor Author

lab-mathias-claussen commented Dec 2, 2019 •
edited
Loading

Hi, the board is moved, currently i struggle with the "board discription", i guess it's not meant in the board.txt but somewhere here ?

Schematics and KiCad Files can be found here : https://github.com/ElektorLabs/180516-Elektor_LoRa_Node

Project discrition can be found here: https://www.elektormagazine.com/labs/lorawan-node-experimental-platform

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Dec 2, 2019

Thanks @lab-mathias-claussen
anyway it seems you made a mistake when updating the boards.txt as it includes lot of changes not related to the new variant.

For the board description, this is mainly to review the variant (pin mapping, ...) and having a link to add in the README.md if this PR is merged.

@lab-mathias-claussen
Copy link
Copy Markdown
Contributor Author

lab-mathias-claussen commented Dec 2, 2019

Hi,

the board.txt should be fixed now. I am sorry for the messed up board.txt.

fpistm and others added 6 commits December 2, 2019 14:55
@fpistm
Shorten variant folder
599c722 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Astyle fix
58fd7f6 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Fix SYS_WKUP pins
173fa74 
Even if not available in in LQFP48 package.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Clean up code
7f962c9 
Remove useless comments
Fix typo

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Enable HAL DAC module
d6c5027 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@lab-mathias-claussen
Merge pull request #1 from fpistm/pr-810-review
757c51f 
PR 810 review
fpistm
fpistm requested changes Dec 2, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lab-mathias-claussen
I forgot to check duplicated pins in the PeripheralPins.c
See my comment, this will allow to save space.

Comment thread variants/ELEKTOR_F072C8/PeripheralPins.c
Comment thread variants/ELEKTOR_F072C8/PeripheralPins.c Outdated
lab-mathias-claussen and others added 2 commits December 2, 2019 16:33
@lab-mathias-claussen @fpistm
Update variants/ELEKTOR_F072C8/PeripheralPins.c
22cc421 
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
To svae space duplicated PINS have been commented out
68887e6 
Duplicated PINS in PeripheralsPins.c have been commented out,.
fpistm
fpistm requested changes Dec 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lab-mathias-claussen
Simply remove the ADC_RESOLUTION definition and this will be ok.

Comment thread variants/ELEKTOR_F072C8/variant.h Outdated
Comment thread variants/ELEKTOR_F072C8/variant.h Outdated
Comment thread variants/ELEKTOR_F072C8/variant.h Outdated
Comment thread variants/ELEKTOR_F072C8/variant.h Outdated
Comment thread variants/ELEKTOR_F072C8/variant.h Outdated
lab-mathias-claussen and others added 5 commits December 3, 2019 07:42
@lab-mathias-claussen @fpistm
Update variants/ELEKTOR_F072C8/variant.h
31525e5 
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
@lab-mathias-claussen @fpistm
Update variants/ELEKTOR_F072C8/variant.h
0668c75 
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
@lab-mathias-claussen @fpistm
Update variants/ELEKTOR_F072C8/variant.h
a9177a5 
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
@lab-mathias-claussen @fpistm
Update variants/ELEKTOR_F072C8/variant.h
7b0bc9c 
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
@lab-mathias-claussen @fpistm
Update variants/ELEKTOR_F072C8/variant.h
f7d6e55 
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Fixed Style issues in PeripheralPins.c
06afe64 
AStyle fixed as travis build failed
@fpistm fpistm merged commit ad09a48 into stm32duino:master Dec 3, 2019
@fpistm fpistm added this to the 1.8.0🎄 🎅 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpistm fpistm fpistm approved these changes

Assignees

No one assigned

Labels

new variant Add support of new bard

Projects

None yet

Milestone

1.8.0🎄 🎅

Development

Successfully merging this pull request may close these issues.

2 participants

@lab-mathias-claussen @fpistm