new variant: PRNTRv2#837
Merged
fpistm merged 1 commit intostm32duino:masterfrom Dec 19, 2019
Merged
Conversation
ghent360
force-pushed
the
variant-prntrv2
branch
from
d44f48d to
6d2e854
Compare
fpistm
reviewed
Dec 18, 2019
ghent360
force-pushed
the
variant-prntrv2
branch
from
6d2e854 to
5a4817f
Compare
Member
|
@ghent360 |
Contributor
Author
|
Sure how do I do that?
…On Wed, Dec 18, 2019 at 8:04 AM Frederic Pillon ***@***.***> wrote:
@ghent360 <https://github.com/ghent360>
One question:
maybe it should be fine to merge the two PRNTR and use switch for the
difference?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#837?email_source=notifications&email_token=AB6FRVXRMBDAEV3PLLEJSOTQZJCZ5A5CNFSM4J4HE3T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHGTOFY#issuecomment-567097111>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6FRVWEYK4ZZFMSUYEXWY3QZJCZ5ANCNFSM4J4HE3TQ>
.
|
Member
I do the same for #828 In fact you can use the switch : and in the boards.txt point to the same variant folder. |
Contributor
Author
|
ok. I'll update it. Give me a few days.
…On Wed, Dec 18, 2019 at 11:08 AM Frederic Pillon ***@***.***> wrote:
Sure how do I do that?
I do the same for #828
<#828>
In fact you can use the switch : ARDUINO_<board>
In your case:
ARDUINO_PRNTR_F407_V1
or
ARDUINO_PRNTR_V2
and in the boards.txt point to the same variant folder.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#837?email_source=notifications&email_token=AB6FRVVVE3V3XDK64G5SKX3QZJYK7A5CNFSM4J4HE3T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHE4SI#issuecomment-567168585>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6FRVQ24OWRRSGZ6K2LE2DQZJYK7ANCNFSM4J4HE3TQ>
.
|
ghent360
force-pushed
the
variant-prntrv2
branch
from
5a4817f to
10a4a87
Compare
Contributor
Author
|
merged into a single variant. |
fpistm
approved these changes
Dec 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New 3D printer board variant PRNTR board V2. Design files at
https://github.com/ghent360/PrntrBoardV2
This PR fixes/implements the following features
Validation
Tested Marlin bugfix-2.0.x branch. Tested HardwareTimers, HardwareSerial, USB CDC, SD-card SDIO, I2C (TwoWire), SPI, GPIO, ADC, Servo