Skip to content

HardwareTimer: Clear IT flag only if callback not previously configured#852

Merged
fpistm merged 1 commit intostm32duino:masterfrom
ABOSTM:HARDWARETIMER_CLEAR_IT_ONLY_WHEN_NOT_PREVIOUSLY_CONFIGURED
Jan 13, 2020
Merged

HardwareTimer: Clear IT flag only if callback not previously configured#852
fpistm merged 1 commit intostm32duino:masterfrom
ABOSTM:HARDWARETIMER_CLEAR_IT_ONLY_WHEN_NOT_PREVIOUSLY_CONFIGURED

Conversation

@ABOSTM
Copy link
Copy Markdown
Contributor

@ABOSTM ABOSTM commented Jan 3, 2020

Summary

HardwareTimer: Clear IT flag only if callback not previously configured
rework #806 after discussion with @matthijskooijman

@fpistm fpistm added enhancement New feature or request waiting feedback Further information is required labels Jan 3, 2020
@fpistm fpistm self-requested a review January 13, 2020 09:27
Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm removed the waiting feedback Further information is required label Jan 13, 2020
@fpistm fpistm merged commit a6f7a98 into stm32duino:master Jan 13, 2020
@matthijskooijman
Copy link
Copy Markdown
Contributor

Looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants