Skip to content

Support Fysetc S6#992

Merged
fpistm merged 22 commits intostm32duino:masterfrom
GerogeFu:fysetc_s6
Mar 19, 2020
Merged

Support Fysetc S6#992
fpistm merged 22 commits intostm32duino:masterfrom
GerogeFu:fysetc_s6

Conversation

@GerogeFu
Copy link
Copy Markdown
Contributor

@GerogeFu GerogeFu commented Mar 17, 2020

I want to support compilation of S6 3d printer board in arduino. And the board is here : https://github.com/FYSETC/FYSETC-S6

@fpistm fpistm requested a review from ABOSTM March 17, 2020 08:12
@fpistm fpistm added the new variant Add support of new bard label Mar 17, 2020
Copy link
Copy Markdown
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GerogeFu ,
Thanks for this PR.

Comment thread variants/FYSETC_S6/ldscript.ld Outdated
Comment thread variants/FYSETC_S6/ldscript.ld Outdated
Comment thread README.md Outdated
Comment thread variants/FYSETC_S6/PeripheralPins.c
@fpistm
Copy link
Copy Markdown
Member

fpistm commented Mar 17, 2020

One question, on the store of the official website https://www.fysetc.com, why there is no reference to the S6, only the F6?

@GerogeFu
Copy link
Copy Markdown
Contributor Author

One question, on the store of the official website https://www.fysetc.com, why there is no reference to the S6, only the F6?

Oh , we did not update the web page , we will update it as soon as possible. Most we sell at aliexpress : https://es.aliexpress.com/item/4000346401899.html?spm=a2g0o.productlist.0.0.135a375cH7PiFe&algo_pvid=b5bd985d-04b0-4085-8dc5-45b28f3d5cf3&algo_expid=b5bd985d-04b0-4085-8dc5-45b28f3d5cf3-0&btsid=0bb47a1915844419924293577e2dab&ws_ab_test=searchweb0_0,searchweb201602_,searchweb201603_

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Mar 17, 2020

OK thanks for the answer. I guess it is a new board, so ?

@GerogeFu
Copy link
Copy Markdown
Contributor Author

OK thanks for the answer. I guess it is a new board, so ?

It's not fresh new ,but still a new board. I used to compile the firmware using vscode+platformio , you can find the pio file here https://github.com/FYSETC/Marlin-2.0.x-FYSETC/blob/S6/2.0.x/platformio.ini , and you can search FYSETC_S6 to find the compile options, and i don't know if there are extra compile flags needed to make it work in arduino. Will you check for me ?

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Mar 18, 2020

Will you check for me ?

Unfortunately, we do not use PIO, so I can't help on this.
Anyway thanks for sharing I better understand how you use it.
As @ABOSTM said, you also have to add -DVECT_TAB_OFFSET= to the boards.txt else this is not coherent with your linker script.

Copy link
Copy Markdown
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the typo in ldscript.ld script, everything looks good to me.
As said @fpistm, we can't help on pio. So tell us whether you need to add switches or we can merge.

Comment thread variants/FYSETC_S6/ldscript.ld Outdated
Co-Authored-By: Alexandre Bourdiol <50730894+ABOSTM@users.noreply.github.com>
@GerogeFu
Copy link
Copy Markdown
Contributor Author

I think it's ok to merge.

Copy link
Copy Markdown
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread README.md Outdated
Comment thread variants/FYSETC_S6/variant.h Outdated
Comment thread variants/FYSETC_S6/variant.h Outdated
Comment thread variants/FYSETC_S6/variant.cpp Outdated
Comment thread variants/FYSETC_S6/variant.h Outdated
Comment thread variants/FYSETC_S6/PeripheralPins.c
Comment thread variants/FYSETC_S6/PeripheralPins.c
Comment thread boards.txt Outdated
Comment thread variants/FYSETC_S6/variant.h Outdated
Comment thread variants/FYSETC_S6/variant.h Outdated
GerogeFu and others added 7 commits March 18, 2020 18:18
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Comment thread variants/FYSETC_S6/variant.h Outdated
@fpistm fpistm added this to the 1.9.0 milestone Mar 18, 2020
Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the update.
Still the PeripheralPins.c to add comments like you do for the old one.
Else all is OK for me. 👍

Comment thread variants/FYSETC_S6/PeripheralPins.c Outdated
Comment thread variants/FYSETC_S6/variant.h Outdated
Comment thread variants/FYSETC_S6/PeripheralPins.c Outdated
Comment thread variants/FYSETC_S6/PeripheralPins.c Outdated
@fpistm fpistm merged commit f5fb148 into stm32duino:master Mar 19, 2020
@GerogeFu
Copy link
Copy Markdown
Contributor Author

Thanks all these gentlemen helping me for this PR. Thanks.

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Mar 23, 2020

Welcome. Thanks too for all your update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new variant Add support of new bard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants