Skip to content

feat: switched to ArduinoCore-API usage#19

Open
Aymane-ST wants to merge 1 commit intostm32duino:mainfrom
Aymane-ST:api/dev
Open

feat: switched to ArduinoCore-API usage#19
Aymane-ST wants to merge 1 commit intostm32duino:mainfrom
Aymane-ST:api/dev

Conversation

@Aymane-ST
Copy link
Copy Markdown

@Aymane-ST Aymane-ST requested a review from fpistm April 21, 2026 08:11
@Aymane-ST Aymane-ST added the enhancement New feature or request label Apr 21, 2026
Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check to warn users if they use non compatible core version like here:
https://github.com/stm32duino/STM32RTC/blob/db5137f8a414270a4f86d7eeecf250813664b8e1/src/STM32RTC.h#L41-L43

You can use version 2.12.0 ; means > 0x020C0000

@github-project-automation github-project-automation Bot moved this from In progress to Needs review in STM32duino libraries Apr 21, 2026
Comment thread src/NMEA_parser.h Outdated
@Aymane-ST Aymane-ST force-pushed the api/dev branch 4 times, most recently from 7e76ec9 to 2a6713d Compare April 27, 2026 13:01
ref: Arduino_Core_STM32#2879

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Aymane Bahssain <aymane.bahssain@st.com>
@fpistm
Copy link
Copy Markdown
Member

fpistm commented Apr 28, 2026

Hi @cparata
I've updated the PR from @Aymane-ST.
It allows to not add breaking changes.
Build passed for old version of the core, the new one with ArduinoCore-API support and with Arduino samd core.
Let me know if you think it is better.

@fpistm fpistm requested review from cparata and fpistm April 28, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

3 participants