fix: caret positioning for tabs and soft-break lines#3677
Open
garhm wants to merge 5 commits into
Open
Conversation
- anchor tab caret Y to line top for trailing tab (was bottom-aligned tab box) - position soft-break continuation caret at line start, alignment-aware (left/center/right), instead of the page right edge
- anchor tab caret Y to line top for trailing tab (was bottom-aligned tab box) - position soft-break continuation caret at line start, alignment-aware (left/center/right), instead of the page right edge
caio-pizzol
approved these changes
Jun 8, 2026
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@garhm the code path looks right, and I verified this against the real painter DOM.
i pushed a follow-up commit with the missing coverage: behavior tests for soft-break continuation caret geometry and trailing tab Y, plus unit assertions for the painter contracts and zoom/RTL cases.
lgtm once CI is green.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(left/center/right), instead of the page right edge