fix: keep CLI JSON output parseable#3678
Closed
caio-pizzol wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
622e843 to
14ea06b
Compare
Contributor
Agent docs auditFound deterministic findings on 1 changed agent-doc item(s).
|
14ea06b to
4021d1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3257 with a CLI-boundary fix.
superdoc info --jsoncould emit library diagnostics on stdout whenNODE_ENVwas unset, which made the JSON envelope unparseable. The fix keeps protocol ownership at the executable boundary instead of mutatingconsoleinside importable APIs.What changed:
apps/cli/src/main.ts;apps/cli/src/index.tsremains importableconsole.*for one-shot JSON mode, because success uses stdout and failures use stderrconsole.log/console.info/console.debugto stderr only forhost, where stdout is JSON-RPC--quietconsole.debugdist/index.jstodist/main.jsValidation:
git diff --check HEAD~1..HEADrgbun build apps/cli/src/main.ts --packages external --outfile /tmp/superdoc-cli-main-final-review.jsnode .github/scripts/agent-docs-l1.mjs --target .confirms the newevals/AGENTS.mdbroken path finding is gone