Skip to content

fix(ci): run the full workspace test suite - #44

Merged
suradet-ps merged 1 commit into
mainfrom
fix/ci-test-scope
Oct 17, 2026
Merged

suradet-ps merged 1 commit into
mainfrom
fix/ci-test-scope

Conversation

@suradet-ps

Copy link
Copy Markdown
Owner

Summary

Fixes #39. CI ran cargo test --lib, which builds only library targets. That meant:

  • the two unit tests in crates/app/src/state.rs (the crate is a binary target) never ran;
  • none of the doctests ran, because --lib excludes them.

Verified locally:

cargo test --lib    # 35 tests (models 4, highlighter 13, renderer 18)
cargo test --workspace
  # app 2, highlighter 13, models 4, renderer 18, doctests 9 (5 + 4)

Changes

  • .github/workflows/ci.yml: the Test job now runs cargo test --workspace, which covers all unit tests from every target plus doctests.
  • docs/CONTRIBUTING.md: updated the job table and the local checks list to match.
  • docs/ROADMAP.md: updated the CI summary line to match.

Verification

cargo test --workspace

46 tests run and pass: 37 unit tests (including the 2 app tests that CI previously skipped) plus 9 doctests.

The app crate compiles and runs tests natively (only the tests execute, no WASM runtime is involved), so the new command needs no additional CI infrastructure.

CI ran 'cargo test --lib', which only builds library targets. The two unit tests in crates/app/src/state.rs (a binary target) never ran, and the nine doctests never ran either. 'cargo test --workspace' runs unit tests from all targets plus doctests, raising the executed test count from 35 to 46.

Updates the CONTRIBUTING.md job table and local checklist, and the ROADMAP CI summary, to match. Closes #39.
@vercel

vercel Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
codeshot Ready Ready Preview Oct 17, 2026 3:01am UTC

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0a51d729-a709-42ab-9ea7-56ed15204501
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@suradet-ps
suradet-ps merged commit 09a587b into main Oct 17, 2026
14 checks passed
@suradet-ps
suradet-ps deleted the fix/ci-test-scope branch October 17, 2026 03:25

This branch was successfully deployed

1 active deployment
Preview — 24fae5a6 Deployed Oct 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI skips the app tests and all doctests (cargo test --lib)

1 participant