Repository navigation
fix(ci): run the full workspace test suite - #44
Merged
Merged
Conversation
CI ran 'cargo test --lib', which only builds library targets. The two unit tests in crates/app/src/state.rs (a binary target) never ran, and the nine doctests never ran either. 'cargo test --workspace' runs unit tests from all targets plus doctests, raising the executed test count from 35 to 46. Updates the CONTRIBUTING.md job table and local checklist, and the ROADMAP CI summary, to match. Closes #39.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #39. CI ran
cargo test --lib, which builds only library targets. That meant:crates/app/src/state.rs(the crate is a binary target) never ran;--libexcludes them.Verified locally:
Changes
.github/workflows/ci.yml: the Test job now runscargo test --workspace, which covers all unit tests from every target plus doctests.docs/CONTRIBUTING.md: updated the job table and the local checks list to match.docs/ROADMAP.md: updated the CI summary line to match.Verification
46 tests run and pass: 37 unit tests (including the 2 app tests that CI previously skipped) plus 9 doctests.
The app crate compiles and runs tests natively (only the tests execute, no WASM runtime is involved), so the new command needs no additional CI infrastructure.