Repository navigation
fix(ui): replace mojibake in custom scale tooltip - #51
Merged
suradet-ps merged 1 commit intoOct 22, 2026
Merged
Conversation
|
@O1sumitkumar is attempting to deploy a commit to the suradet pratomsak's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
@O1sumitkumar Thanks for fix. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
titletooltip on the custom scale number input incrates/app/src/controls.rsreadCustom scale (1โ€“12). The en dash had been saved as UTF-8 bytes re-decoded as Thai (TIS-620/CP874) text. This PR replaces the garbled characters with a plain ASCII hyphen, so the tooltip readsCustom scale (1-12). That is the first expected value in the issue.I used an ASCII hyphen rather than re-inserting an en dash so the file has no non-ASCII characters left that could be mis-decoded again. (The leading UTF-8 BOM on line 1 is left as is.) This is a one-line, string-only change. No logic is touched.
How verified
e0 b9 82 e2 82 ac e2 80 9cbetween1and12, which is the mojibake for an en dash.main(66 blobs from the git tree) and grepped for the mojibake pattern. Only this line matched, and after the change no non-ASCII characters are left incontrols.rsexcept the existing BOM.title="..."attribute.Fixes #34