Skip to content

fix(ui): replace mojibake in custom scale tooltip - #51

Merged
suradet-ps merged 1 commit into
suradet-ps:mainfrom
O1sumitkumar:fix/scale-tooltip-mojibake-34
Oct 22, 2026
Merged

suradet-ps merged 1 commit into
suradet-ps:mainfrom
O1sumitkumar:fix/scale-tooltip-mojibake-34

Conversation

@O1sumitkumar

Copy link
Copy Markdown
Contributor

What changed

The title tooltip on the custom scale number input in crates/app/src/controls.rs read Custom scale (1โ€“12). The en dash had been saved as UTF-8 bytes re-decoded as Thai (TIS-620/CP874) text. This PR replaces the garbled characters with a plain ASCII hyphen, so the tooltip reads Custom scale (1-12). That is the first expected value in the issue.

I used an ASCII hyphen rather than re-inserting an en dash so the file has no non-ASCII characters left that could be mis-decoded again. (The leading UTF-8 BOM on line 1 is left as is.) This is a one-line, string-only change. No logic is touched.

How verified

  • Checked the bytes of line 438 before the change. They were e0 b9 82 e2 82 ac e2 80 9c between 1 and 12, which is the mojibake for an en dash.
  • Fetched every text file on main (66 blobs from the git tree) and grepped for the mojibake pattern. Only this line matched, and after the change no non-ASCII characters are left in controls.rs except the existing BOM.
  • I did not run the cargo/trunk CI jobs locally. The change only edits a string literal inside an existing title="..." attribute.

Fixes #34

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

@O1sumitkumar is attempting to deploy a commit to the suradet pratomsak's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 01ac2309-82d8-4b33-994b-99f30ca3baef
📥 Commits

Reviewing files that changed from the base of the PR and between e339084 and 12acd01.

📒 Files selected for processing: 1
  • crates/app/src/controls.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
codeshot Ready Ready Preview Oct 22, 2026 12:22am UTC

@suradet-ps

Copy link
Copy Markdown
Owner

@O1sumitkumar Thanks for fix.

@suradet-ps
suradet-ps merged commit bcbe474 into suradet-ps:main Oct 22, 2026
14 checks passed

This branch was successfully deployed

1 active deployment
Preview — 12acd01d Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Custom scale tooltip contains mojibake characters

2 participants