Link reports to original LeetCode problems by ga-1113 · Pull Request #334 · sysprog21/codetrial

ga-1113 · 2026-10-17T06:49:53Z

The completed report now shows an Original problem link directly below its title. The link uses the published problem map to open the corresponding LeetCode page.

The same reference appears in the immediate report, Past attempts, replay, and downloaded Markdown. The lobby loads the map only when a saved report is opened or exported. Unknown or malformed mappings leave the line hidden, and the active interview view is unchanged.

Checks: 138 lobby browser tests, 70 render tests, and 8 history tests passed. Prettier 3.9.9 and ESLint 10.12.0 passed for the changed JavaScript files; the local app was manually tested.

Closes #152

jserv

Check CONTRIBUTING.md carefully.

Improve git commit messages per https://cbea.ms/git-commit/ :

Don’t make the same mistakes again! Run make hooks in advance.

jserv · 2026-10-22T08:05:56Z

@ga-1113 e40200c merges main into this branch. This project updates a pull request by rebasing onto the latest main and force-pushing to the same branch, never by merging main in (see "Pull requests" in CONTRIBUTING.md). That commit also fails scripts/git-commit-msg.sh: its subject is not git's own merge wording, so it gets no merge exemption, and its body is a single 147-character line where the limit is 72. The hooks make hooks installs would have refused it at commit time, so run make hooks once in this clone first. Then run git rebase onto the latest upstream main, which replays your three commits and drops the merge, resolve the interview-import conflicts there, and force-push. The rebase also clears the failing cargo-audit job, since main already carries that fix.

jserv · 2026-10-22T08:42:27Z

+/// Find the published problem for a completed scenario. The map's key is the
+/// LeetCode URL slug; scenario page names and saved legacy ids both work here.
+/// A malformed map entry cannot turn the fixed destination into another host.
+export function originalProblemForPage(pages, page) {


This puts the published title and LeetCode URL into Past attempts, the replay and the downloaded Markdown. docs/development.md says the opposite: "The title reaches the live interview page only: saved history, the downloaded report and the replay keep the scenario's." It also lists the only reasons web/problem-pages.json is fetched, and every completed report is now one more. Update that paragraph in this PR so the contract matches what ships.

ga-1113 · 2026-10-23T05:55:32Z

Rebased onto the latest main to include the CI fixes from #434 and resolved the conflict.

jserv · 2026-10-23T05:58:12Z

Rebased onto the latest main to include the CI fixes from #434 and resolved the conflict.

Don't leave messages like the above, as GitHub always tracks.

jserv · 2026-10-23T06:14:32Z

+  void loadPageMap()
+    .then((pages) => {
+      if (selected === recordingId)
+        showOriginalProblem(nodes.report, pages, saved.problemId);
+    })
+    .catch(() => {});


No browser test reaches this lookup, or the one renderReport in web/interview.js starts for the report shown right after an interview, which is the case #152 asks for. Only the Past attempts path is driven end to end, so the selected === recordingId guard and the immediate report's link could break with every test still passing. Add one test that finishes an interview and expects the link under the title, and one that opens a second recording before the first lookup settles and checks the first problem's link does not appear on it.

jserv

Rebase latest main branch and resolve conflicts.

Completed reports need a way back to the original problem so readers can revisit the source while reviewing their answers. Include the LeetCode link in completed reports, saved attempts, replays, and Markdown exports. Prevent duplicate exports while the optional problem lookup is pending, and allow retries after it finishes or fails. Add browser coverage for the report shown after an interview and for a late lookup after switching recordings, so stale links cannot appear on another report.

jserv · 2026-10-25T14:24:50Z

+  let timer;
+  try {
+    return await Promise.race([
+      loadPageMap().catch(() => null),


This .catch(() => null) is what lets a download proceed when the map fetch fails or returns malformed JSON. Every test either swaps out loadPageMapForDownload (the download.test.js harness) or only stalls the fetch to hit the timeout (the lobby test), so deleting this catch would leave the suite green while an offline user loses report export. Add a browser test that aborts /problem-pages.json and another that serves invalid JSON, then asserts one Markdown download with no Original problem: line and a re-enabled button.

ColtenOuO · 2026-10-25T15:51:48Z

+  button.disabled = true;
+  try {
+    const at = new Date();
+    const problemPages = await loadPageMapForDownload();


leaveRoom() doesn't know about this wait. Once the report is persisted, Done navigates to / without a confirm. So if /problem-pages.json is still pending, the export is lost when Done is clicked within the next 10s. That happens when the prefetch in renderReport stalled, or when it failed and this call fetches again. Before this change the file was saved synchronously inside the click. Disabling #done while a download is pending, or letting leaveRoom wait for it, would close that gap.

ColtenOuO · 2026-10-25T15:51:48Z


+/// A report can be exported without its optional original-problem link. Bound
+/// only this caller's wait; the shared lookup may still serve other consumers.
+export async function loadPageMapForDownload() {


This is the same bounded wait as loadHistoryPageMap in web/app.js (L1126). The only difference is that the timeout is 10_000 here and requestTimeoutMs there. Exporting one helper from this module, e.g. loadPageMapWithin(ms), and using it in both places would keep the two from drifting. The void loadPageMap().then(... showOriginalProblem ...).catch(() => {}) repeated in app.js, interview.js and replay.js could live next to it too, with replay passing its selected === recordingId check in.

No merge conflicts at the current head.

This comment was marked as resolved.

Sign in to view

jserv reviewed Oct 17, 2026

View reviewed changes

Comment thread web/app.js Outdated

jserv reviewed Oct 17, 2026

View reviewed changes

Comment thread web/render.js

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

ga-1113 force-pushed the issue-152-leetcode-report-link branch from caf95f0 to e40200c Compare October 20, 2026 10:09

This comment was marked as outdated.

Sign in to view

jserv requested changes Oct 21, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

jserv mentioned this pull request Oct 22, 2026

Automate PR review and rebase decisions #427

Merged

ga-1113 changed the title ~~Link original LeetCode problems from reports~~ Link reports to original LeetCode problems Oct 22, 2026

ga-1113 force-pushed the issue-152-leetcode-report-link branch from e40200c to 97fda76 Compare October 22, 2026 08:36

jserv reviewed Oct 22, 2026

View reviewed changes

ga-1113 force-pushed the issue-152-leetcode-report-link branch from 97fda76 to 620efca Compare October 22, 2026 08:56

This comment was marked as outdated.

Sign in to view

ga-1113 force-pushed the issue-152-leetcode-report-link branch from 620efca to 84bd452 Compare October 23, 2026 05:52

jserv reviewed Oct 23, 2026

View reviewed changes

Comment thread web/app.js Outdated

jserv reviewed Oct 23, 2026

View reviewed changes

jserv previously requested changes Oct 25, 2026

View reviewed changes

ga-1113 force-pushed the issue-152-leetcode-report-link branch from 84bd452 to 5b47ed1 Compare October 25, 2026 06:22

jserv reviewed Oct 25, 2026

View reviewed changes

ColtenOuO reviewed Oct 25, 2026

View reviewed changes

Conversation

ga-1113 commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

jserv left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

jserv commented Oct 22, 2026

Uh oh!

jserv Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

ga-1113 commented Oct 23, 2026

Uh oh!

jserv commented Oct 23, 2026

Uh oh!

Uh oh!

jserv Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

jserv left a comment

Choose a reason for hiding this comment

Uh oh!

jserv Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

ColtenOuO Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

ColtenOuO Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ga-1113 commented Oct 17, 2026 •

edited

Loading