Repository navigation
Allow downloading multiple selected interview reports - #453
Open
yucheng922003 wants to merge 1 commit into
Open
yucheng922003 wants to merge 1 commit into
yucheng922003 wants to merge 1 commit into
Conversation
jserv
reviewed
Oct 23, 2026
jserv
reviewed
Oct 23, 2026
jserv
reviewed
Oct 23, 2026
yucheng922003
force-pushed
the
feat/batch-report-download
branch
from
October 23, 2026 13:35
f79990f to
6cde114
Compare
jserv
reviewed
Oct 23, 2026
jserv
reviewed
Oct 23, 2026
Let candidates save multiple attempts without repetitive downloads.
yucheng922003
force-pushed
the
feat/batch-report-download
branch
from
October 23, 2026 16:20
6cde114 to
f056d58
Compare
jserv
reviewed
Oct 24, 2026
Comment on lines
+494
to
+497
| /// The rows of `progressNormalized` unticked for "Download selected". Keyed on | ||
| /// the row objects: a filter change reuses them, so it keeps every choice, and | ||
| /// a reload builds new ones that were never unticked, so it starts all ticked. | ||
| const unselectedAttempts = new WeakSet(); |
Contributor
There was a problem hiding this comment.
Deleting one report brings back every untick. deleteSavedReport calls reloadAfterDelete, which goes through showProgress and normalizeProgressEntries and builds new row objects, so this WeakSet recognizes none of them. If a user unticks A and then deletes B, A is ticked again and the next "Download selected" includes a report they excluded. Key the unticked set on attempt.id (fall back to the row object for rows with no id), clear it only when the history source changes (account vs device), and add a browser test that unticks A, deletes B, and asserts A stays unticked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let candidates save multiple attempts without repe## Summary
Screenshots
Before
After — default state
After — after clicking batch download
After — filtered with no matching reports
Testing
Closes #444titive downloads.
Summary by cubic
Adds checkboxes to past interview attempts so you can download multiple saved reports at once instead of one by one.
Closes #444.
Written for commit f056d58. Summary will update on new commits.