Merge pull request #1296 from tableau/update-dev-notes

Update dev guide to be clarify installing dependencies, running tests, black and mypy

Author: bcantoni

docs/dev-guide.md

@@ -30,12 +30,15 @@ add your contributions to the **development** branch.
 
    ```shell
    git clone git@github.com:<user-name>/server-client-python.git
+   cd server-client-python
    ```
 
-1. Run the tests to make sure everything is passing:
+1. Install dependencies and run the tests to make sure everything is passing:
 
    ```shell
-   python setup.py test
+   python -m pip install --upgrade pip
+   pip install -e .[test] build
+   pytest test
    ```
 
 1. Configure a remote that points to the source (upstream) repository:
@@ -61,7 +64,7 @@ For documentation changes, see the documentation section below.
 ### Code and commit
 
 Here's a quick checklist to follow when coding to ensure a good pull request
-(PR):
+(PR) that will pass the PR checks:
 
 - Only touch the fewest number of files possible while still accomplishing the
   goal.
@@ -71,6 +74,8 @@ Here's a quick checklist to follow when coding to ensure a good pull request
   `black --line-length 120 tableauserverclient samples test` to catch and fix any style
   issues before submitting your pull request. (Run black with the `--check` option if
   you want to check whether formatting is valid without changing any files.)
+- Ensure the Mypy static type checker is still passing by running
+  `mypy --show-error-codes --disable-error-code misc --disable-error-code import tableauserverclient test`.
 - Keep commit messages clean and descriptive.
 
 ### Use git pre-commit hook