Repository navigation
golink: handle db.Load errors in serveDetail and serveDelete - #265
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
serveDetail and serveDelete only handled fs.ErrNotExist from db.Load. Any other error left link nil, and the following link.Short or link.Owner access panicked instead of returning an error to the client. Return a 500 the same way serveSave does. Fixes tailscale#257 Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return a 500 response from
serveDetailandserveDeletewhen loading the link fails.Both handlers checked only for
fs.ErrNotExistafterdb.Load. Any other error, such as a failed database query, leftlinknil, and the next access tolink.Shortorlink.Ownerpanicked.serveSavealready returns a 500 for this case. This change does the same inserveDetailandserveDelete.Testing:
TestServeDetailDeleteDBError, which closes the database and requests/.detail/fooand/.delete/foo.go vet .andgo test .pass.Fixes #257