Repository navigation
server: split tmemes server wiring into server package - #12
Merged
Merged
Conversation
bailey-ts
force-pushed
the
bailey/tmemes-eks
branch
from
September 4, 2026 18:39
d17473f to
5bca126
Compare
bailey-ts
marked this pull request as ready for review
September 9, 2026 18:06
creachadair
approved these changes
Sep 9, 2026
Member
There was a problem hiding this comment.
Huh, it's weird it didn't recognize this one as a rename like the others.
Member
There was a problem hiding this comment.
Oh, I guess because of the CSRF updates.
| // callers that serve Handler directly without CSRF middleware. | ||
| CSRFToken func(*http.Request) string | ||
| // CSRFFieldName is the browser form field that carries CSRFToken. | ||
| CSRFFieldName string |
Member
There was a problem hiding this comment.
We should probably require this to be non-empty if CSRFToken is non-nil.
Extract the tmemes HTTP application into an importable server package while retaining cmd/tmemes as the standalone raw tsnet command. Let callers supply its database, LocalAPI client, and optional browser route security hooks; listener, state, and debug lifecycle remain with the command wrapper. Signed-off-by: Bailey Jayes <bailey@tailscale.com>
bailey-ts
force-pushed
the
bailey/tmemes-eks
branch
from
September 9, 2026 19:14
5bca126 to
dd8ebd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates corp/#43531
Extract the tmemes HTTP application into an importable server package while retaining cmd/tmemes as the standalone raw tsnet command. Let callers supply its database, LocalAPI client, and optional browser route security hooks; listener, state, and debug lifecycle remain with the command wrapper.