Skip to content

server: split tmemes server wiring into server package - #12

Merged
bailey-ts merged 1 commit into
mainfrom
bailey/tmemes-eks
Sep 9, 2026
Merged

bailey-ts merged 1 commit into
mainfrom
bailey/tmemes-eks

Conversation

@bailey-ts

@bailey-ts bailey-ts commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Updates corp/#43531

Extract the tmemes HTTP application into an importable server package while retaining cmd/tmemes as the standalone raw tsnet command. Let callers supply its database, LocalAPI client, and optional browser route security hooks; listener, state, and debug lifecycle remain with the command wrapper.

@bailey-ts
bailey-ts marked this pull request as ready for review September 9, 2026 18:06
Comment thread server/ui/upload.tmpl

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, it's weird it didn't recognize this one as a rename like the others.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess because of the CSRF updates.

Comment thread server/api.go
// callers that serve Handler directly without CSRF middleware.
CSRFToken func(*http.Request) string
// CSRFFieldName is the browser form field that carries CSRFToken.
CSRFFieldName string

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably require this to be non-empty if CSRFToken is non-nil.

Extract the tmemes HTTP application into an importable server
package while retaining cmd/tmemes as the standalone raw tsnet
command. Let callers supply its database, LocalAPI client, and
optional browser route security hooks; listener, state, and
debug lifecycle remain with the command wrapper.

Signed-off-by: Bailey Jayes <bailey@tailscale.com>
@bailey-ts
bailey-ts merged commit ea9f1c4 into main Sep 9, 2026
1 check passed
@bailey-ts
bailey-ts deleted the bailey/tmemes-eks branch September 9, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants