Underline the correct occurrence of an unsupported type in --value(…)

[otarampinelli]

Summary

When an unsupported bare value data type is repeated in --value(…), every warning underlines the first occurrence:

@utility paint-* {
  paint: --value(color, [color], color);
}

Before, both warnings pointed at the first color:

--value(color,[color],color)
        ^^^^^

This happened because the offset was found by replacing every word matching the type with a sentinel in a cloned node and then calling indexOf on the printed result, which always returns the first match.

Now the offset is computed from the node's position instead: thame, plus the (, plus the printed length of the arguments before it.

Each warning points at its own occurrence:

--value(color,[color],color)
        ^^^^^

--value(color,[color],color)
                      ^^^^^

Test plan

Added a test in packages/tailwindcss/src/utilities.test.ts. It spies on console.warn and checks that the two warnings underline the first and the last color respectively.

cd packages/tailwindcss
pnpm vitest run src/utilities.test.ts -t "repeated unsupported data type"

Evidences

https://stackblitz.com/edit/github-yq34h5eo?file=input.css

before fix:

after fix:

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 061885e1-aaa6-411b-98fb-e7f7e59d11fc

📥 Commits

Reviewing files that changed from the base of the PR and between 7cc5e73 and 0c89215.

📒 Files selected for processing: 1

• CHANGELOG.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

Walkthrough

The utility now calculates unsupported bare-value warning positions from the argument index and preceding serialized arguments. A regression test checks separate underlines for two unsupported color values in one function call. The changelog records this fix.

Priority: ⬇️ Low

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 0c892

Repeated unsupported-type warnings are intended to point to their respective occurrences, and the supplied regression assertion checks both. No actionable merge risk is evident.

Pre-merge checks: 4

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: correcting the underlined occurrence of repeated unsupported types in --value(…).
Description check		The description directly explains the bug, the implementation change, the added test, and the expected warning output. It is related to the changeset.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

_{Reviews (3) · Last reviewed commit: "Add changelog entry" · Reviewed by Greptile}

[RobinMalfait]

Thanks for the PR! Computing the offset from the node position is simpler than the sentinel trick, and each warning now points at its own occurrence. Nice test too.

_{Sent by an AI assistant on behalf of @RobinMalfait.}