Repository navigation
Conversation
The scan path rebuilt the engine only on the refresh that observed a viewport change, but RefreshGameDisplayConfiguration commits the new viewport first. A failed rebuild (or a concurrent scan that missed the one-shot flag) left the engine on the old scale until restart, and a display-DPI-only change rebuilt needlessly. - Rebuild when the published engine's scale differs from the scale for the committed viewport, so failures retry on the next scan. - Detect minimized Tarkov windows and keep the previous viewport on scan-path refreshes instead of flipping to the Graphics.ini/monitor fallback and back (each flip cost a synchronous rebuild on a click). Claude-Session: https://claude.ai/code/session_01QFKiA2aswHyp8SnpraLxE2
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 37 minutes. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RefreshGameDisplayConfigurationcommits the new viewport first. If that rebuild threw, later scans saw no change and the engine kept the old scale until restart (wrong-scale template matching).What
Scalediffers from the scale for the committed viewport (GameDisplayRefreshPolicy.EngineScaleIsStale), so a failed rebuild retries next scan and DPI-only changes no longer rebuild.WindowsGameDisplayServicereports a minimized Tarkov window (IsIconic); scan-path refreshes keep the previous configuration (ShouldApply). Explicit refreshes from settings still apply.Validation
dotnet test414/414; CodeRabbit: no findings.Not proven
RatScannerMain/RatConfigneeds a live-game check: windowed EFT, minimize, click on the desktop, restore, then icon scan; Log.txt should show noengine.rebuild_on_scan_path.https://claude.ai/code/session_01QFKiA2aswHyp8SnpraLxE2