Repository navigation
fix(scan): separate name/icon cooldowns; skip name scans while cursor hidden - #76
Merged
Merged
Conversation
… hidden - Name scans run on every left click and shared one 300 ms throttle with Shift+click icon scans, so any click shortly before an icon scan silently dropped it. Each scan kind now has its own throttle. - Every shot in raid triggered a name scan: a GDI capture of the game frame plus display detection. Skip name scans (and the auto full-screen name scan) while GetCursorInfo reports the system cursor hidden. Unknown cursor state never blocks; NameScan.SkipWhenCursorHidden in config.cfg turns the gate off for setups that hide the system cursor in menus. Counted as scan.name_skipped_cursor_hidden. Claude-Session: https://claude.ai/code/session_01QFKiA2aswHyp8SnpraLxE2
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 3 seconds. View limit details
Comment |
# Conflicts: # docs/agent-context/performance-diagnostics.md
# Conflicts: # tests/RatScanner.Tests/ConfigurationMigrationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ScanThrottlewith Shift+click icon scans. Any click within 300 ms before an icon scan silently dropped it (visible only asscan.throttled), which users experience as inconsistent icon scans.What
_nameScanThrottleand_iconScanThrottle(sameNameScan.CooldownMs).NameScanGate.ShouldSkip: skipNameScanand the autoNameScanScreenwhileGetCursorInforeports the system cursor hidden. Unknown state (call failed, or touch/penCURSOR_SUPPRESSED) never blocks. Counterscan.name_skipped_cursor_hidden.NameScan.SkipWhenCursorHidden(config.cfg, default on, no UI), persisted with the other NameScan keys.Validation
NameScanGateTests(hidden/shown/unknown/disabled; mutation fails the unknown case); config default + disable round-trip test.GetCursorInfostruct verified at runtime (size 24,CURSOR_SHOWINGon the desktop).dotnet test413/413; CodeRabbit finding (suppressed cursor) fixed in 251868a.Not proven
SkipWhenCursorHidden=Falseunder[NameScan]and report it.https://claude.ai/code/session_01QFKiA2aswHyp8SnpraLxE2