fix(state): derive own plugin data dir to avoid cross-plugin leak#1
Closed
suharvest wants to merge 1 commit into
Closed
fix(state): derive own plugin data dir to avoid cross-plugin leak#1suharvest wants to merge 1 commit into
suharvest wants to merge 1 commit into
Conversation
CLAUDE_PLUGIN_DATA can be exported by an unrelated plugin (e.g. codex companion) into the shared env, causing opencode state to land in another plugin's data directory. Derive our own data dir from the script's install path instead, falling back to CLAUDE_PLUGIN_DATA only when it already names an opencode-scoped dir. Add OPENCODE_COMPANION_DATA as an explicit override.
This was referenced Apr 18, 2026
Author
|
Superseded by #5 — consolidated hardening suite including this PR's work plus server/auto-heal/SAFETY_HEADER/wait-and-result on top. Closing since no review activity in 2+ days and the follow-on work builds on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE_PLUGIN_DATAcan be exported into the shared env by an unrelated plugin (e.g. a codex companion). When that happens, opencode-companion's state lands in that plugin's data directory instead of its own.<root>/plugins/cache/<owner>-<repo>/<plugin>/<version>/...and assigns per-plugin data at<root>/plugins/data/<plugin>-<owner>-<repo>/, so the mapping is deterministic.CLAUDE_PLUGIN_DATAonly when its basename already matches opencode; otherwise ignore it.OPENCODE_COMPANION_DATAas an explicit opt-in override for users who want a custom location.Test plan
plugins/data/opencode-*dir even whenCLAUDE_PLUGIN_DATApoints at another pluginplugins/cache/...layout) still falls back to/tmp/opencode-companion