Unwrap System Nexus Operations in event history#1017
Open
spkane31 wants to merge 2 commits into
Open
Conversation
spkane31
force-pushed
the
spk/system-nexus-operations
branch
from
8f5fd90 to
f53981d
Compare
Contributor
|
Could add new or amend existing functional tests. It'd be great to have some assertion both human readable output and json. |
chaptersix
reviewed
May 21, 2026
| // "__temporal_system" endpoint, replacing the generic NexusOperation* name with the | ||
| // actual operation name + event-type suffix. Returns "" for all other events. | ||
| // Populates s.systemNexusOps when it encounters a qualifying Scheduled event. | ||
| func (s *structuredHistoryIter) systemNexusOpDisplayName(event *history.HistoryEvent) string { |
Contributor
There was a problem hiding this comment.
we also have a --reverse flag. Could you add a test for this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
workflow show(table and --detailed modes) now displays the actual operation name instead of the genericNexusOperationScheduled/NexusOperationCompletedevent type when the Nexus endpoint is__temporal_system.workflow describeno longer includes pending Nexus operations on the__temporal_systemendpoint in the "Pending Nexus Operations" list or count.Why?
System Nexus operations (endpoint
__temporal_system) are implementation details of high-level SDK operations likeSignalWithStartWorkflowExecution. Surfacing them asNexusOperationScheduled/NexusOperationCompletedevents is confusing. By unwrapping the operation name, the history and describe output reflect what the workflow actually did at a semantic level. Similarly, pending system operations in describe are noise the user has no actionable interest in.Checklist
Closes NA
How was this tested:
commands.workflow_show_test.gocovering all six NexusOperation event types, the non-system-endpoint no-op path, and the missing-scheduled-event (reverse traversal / orphaned completion) path.temporal workflow show -w <id>against a live workflow that executes aSignalWithStartWorkflowExecutionsystem nexus operation and confirmed events 5 and 6 now show asSignalWithStartWorkflowExecutionScheduledandSignalWithStartWorkflowExecutionCompleted.