Organize workers/go#358
Open
THardy98 wants to merge 1 commit into
Open
Conversation
…r shared worker code (i.e. workflows, activities, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Purely organizational change.
Organizing
workers/gointo 3 top-level dirs:harness: harness that exposes worker/client helpers and gRPC methods forprojecttestsapps:harness.Appentrypoints, these are build targets and what actually runs on the workerworkerlib: shared code that can be reused betweenharness.Apps (i.e. workflows, activities, etc.)Note that
workers/goshares a singlego.modbetween all tests in the module. This makes it much easier to share code between different app entrypoints and keeps the build logic simple. I took a different approach with the other langs, but I think this is better & simpler.Why?
Clarifies boundaries / cleaner package roles (harness, app, shared code). Better build target model (look inside
workers/go/apps/<x>)