fix: release please configs#418
Merged
Merged
Conversation
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
damacus
reviewed
Feb 25, 2025
damacus
left a comment
damacus
left a comment
Contributor
There was a problem hiding this comment.
Where are we at with this?
This was referenced Mar 17, 2025
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Contributor
Author
|
sorry this fell off my radar |
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
The moby/buildkit:buildx-stable-1 image has no Windows manifest, causing the docker-container driver to fail with "no matching manifest for windows(10.0.26100)/amd64". The Windows runner already has buildx installed as a CLI plugin, so the setup-buildx-action is unnecessary. Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
The windows_os? method checks the target platform name (e.g. ubuntu-24.04), not the host machine running Kitchen. When running on a Windows host targeting Linux containers, this caused the socket to incorrectly default to unix:///var/run/docker.sock instead of npipe:////./pipe/docker_engine. Replace driver.windows_os? / transport.windows_os? with Gem.win_platform? which correctly detects the actual host operating system. Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
The Windows CI job was attempting to run Linux containers (ubuntu-24.04) on a Windows Docker daemon in Windows container mode, which is impossible. The Docker daemon on GHA windows-latest cannot pull Linux images. Switch the Windows integration test to use actual Windows containers: - Add windows-2022 platform using mcr.microsoft.com/windows/servercore:ltsc2022 - Update workflow matrix to target windows-2022 instead of ubuntu-2404 - Remove DOCKER_DEFAULT_PLATFORM env (not needed for native Windows containers) - Make InSpec cinc-client version check cross-platform Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
…M, not docker exec) Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
…lobal skip) Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
damacus
reviewed
Jun 25, 2026
| "on": | ||
| pull_request: | ||
|
|
||
| env: |
Contributor
There was a problem hiding this comment.
We don't need this if we're using cinc stuff
Contributor
Author
There was a problem hiding this comment.
I ran into issues where cinc_auditor was still installing inspec and running inspec under the hood. This caused the license error on verify phase. We need to do a deeper dive and verify kitchen-cinc auditor is using cinc-auditor and there are no dependencies on inspec or inspec-core.
damacus
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modernizes the kitchen-docker project across four areas: release automation, CI pipeline, integration test tooling, and Windows container support.
Release Please
release-please-config.jsonand.release-please-manifest.jsonfor config-file-based release-please v5 (replaces deprecated inlinerelease-type/package-name/version-fileparams inpublish.yaml)CI Pipeline (
ci.yml→lint.yml)CHEF_LICENSE_KEYsecret injection for licensed toolingdocker/setup-buildx-actionstep from Windows job — themoby/buildkit:buildx-stable-1image has no Windows manifest and the GHAwindows-2022runner already ships buildx as a CLI pluginubuntu-2004withubuntu-2604Integration Test Tooling
kitchen-inspec+ embeddedlib/train/docker.rbwithkitchen-cinc-auditor+cinc-auditor-bin(open-source Cinc equivalents)lib/train/docker.rb(embedded train transport, 126 lines) — uses upstreamtrain-dockergem insteadlib/docker/version.rb(superseded bylib/kitchen/docker/docker_version.rb)test/cookbooks/cinc_testandtest/cookbooks/docker_testcookbooks for integration test suitestest/integration/cinc/inspec/cinc_spec.rb)GemfileandRakefileaccordingly; switched.rubocop.ymlfromchefstyletocookstyle/chefstyleWindows Container Support
windows_os?(which checked the target platform name) withGem.win_platform?(which checks the host OS) in bothdriver.rbandtransport.rb. Without this fix, Kitchen usedunix:///var/run/docker.sockon a Windows host instead ofnpipe:////./pipe/docker_engine.windows-2022platform tokitchen.ymlusingmcr.microsoft.com/windows/servercore:ltsc2022— a true Windows container, since GHAwindows-2022runners run Docker EE in Windows container mode and cannot pull Linux imagesprovision_commandPowerShell one-liner; setscinc_omnibus_rootso Kitchen resolves the correct client path (C:\cinc-project\cinc\bin\cinc-client.bat)verifier: name: dummyfor the Windows platform —cinc_auditoruses WinRM for Windows targets but Windows Server Core containers do not have WinRM configured; verify support is a follow-upIssues Resolved
N/A — proactive modernization and CI fix.
Type of Change
fix— corrects broken Windows CI and updates tooling/release automation.Check List