Repository navigation
fix(pptx): inherit group fill for <a:grpFill/> shapes - #83
Merged
Merged
Conversation
Shapes using <a:grpFill/> now inherit the enclosing group's resolved fill instead of collapsing to transparent, so decorative custGeom line-art that shares one translucent group colour stays visible on import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 1/5 · base
mainShapes using
<a:grpFill/>collapsed to transparent on import, so decorativecustGeomline-art that shares one translucent group colour vanished. They now inherit the enclosing group's resolved fill.Regression test:
grpfill.test.ts. Changeset included.First of a 5-PR stack splitting #79 into reviewable units; merge 1→5.