Skip to content

feature: addition of the ZipArchive adapter#202

Closed
mariusjp wants to merge 1 commit intothephpleague:3.xfrom
mariusjp:feature/zip-archive-adapter
Closed

feature: addition of the ZipArchive adapter#202
mariusjp wants to merge 1 commit intothephpleague:3.xfrom
mariusjp:feature/zip-archive-adapter

Conversation

@mariusjp
Copy link
Copy Markdown

@mariusjp mariusjp commented Mar 6, 2026

To help with:
#201

@maxhelias
Copy link
Copy Markdown
Collaborator

Hello,

I'm afraid it's not that simple :/ We also need to inject the FilesystemZipArchiveProvider which must provide the path to zip that, which can't be resolved at compile time.
The design between ZipAdapter and FilesystemZipArchiveProvider in this state is not suitable for our integration because the FilesystemZipArchiveProvider sets the path to the zip file for the entire set only the in the zip can be set at runtime.

If you find a way to do, I would be glad to review it.

@mariusjp
Copy link
Copy Markdown
Author

mariusjp commented Mar 9, 2026

@maxhelias
I see what you mean by diving into it more deeply. It already felt too easy to do it this way, my apologies for assuming instead of researching.

Gotta say, the entire design of the (Filesystem)ZipArchiveProvider feels weird and needs a major overhaul for it to work in this bundle indeed.

I'm closing this as I don't see an easy fix/change that won't impact the Provider greatly

@mariusjp mariusjp closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants