Repository navigation
COR-11: stop claiming :find returns a set on this Client-API site - #44
Merged
Merged
Conversation
This site runs Datomic Local via the Client API, which returns a vector with duplicates removed, not a set (verified: relation finds return PersistentVector). "Set" is only accurate for the Peer API, which find-specs.edn already covers separately. Also notes that Datomic's pre-aggregation set includes :with variables, not just :find variables. Closes #27 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PersistentVector.Verification
app.core/run-q: result class isPersistentVector, 67 entries, all distinct — confirms "duplicate rows are removed" is accurate.sum/:withexample: sum jumps from 3070 to 9696 with:with ?e, confirming the pre-aggregation collapsing behavior the chapter describes.clojure -X:test: 32 tests, 493 assertions, 0 failures.Closes #27
🤖 Generated with Claude Code