Repository navigation
Fix integer division claim and document get-else limits - #46
Merged
Merged
Conversation
Datomic's / truncates toward zero (like quot), not a floor, and doesn't return a ratio for non-divisible integers. get-else also silently rejects cardinality-many attributes and nil defaults; both limits are now stated and verified against real error text. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/on integers truncates toward zero (likequot), not "rounded down" (a floor) — verified(/ -7 2)returns-3, not-4. Also noted it doesn't return a ratio for non-divisible integers, unlike Clojure's own/(verified(/ 11 9)returns1).get-else's two undocumented limits: it rejects cardinality-many attributes (cardinality-many attrs not supported: :pokemon/type) and anildefault (nil default value not supported) — both error strings verified by actually running the queries against the real database.Closes #25
Test plan
clojure -X:test— 32 tests, 493 assertions, 0 failuresapp.core/run-q, not assumed from the ticket🤖 Generated with Claude Code