Repository navigation
Fix time travel precision gaps and add real as-of code - #47
Merged
Merged
Conversation
Notes excision/:db/noHistory as exceptions to "nothing is lost", names the transaction-time vs valid-time distinction for :tx/released, shows the real (d/as-of db t) call with the generation-to-transaction lookup, tightens the attack-change query to (< ?before ?now) since the data only has increases, rewords since as "looks only at what came after" rather than "opposite of as-of", and explains why :stat/special stays in the schema (Datomic schema only grows). Closes #24 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:db/noHistoryas exceptions to "nothing is lost":tx/releasedvs:db/txInstant(d/as-of db t)call, including the generation-to-transaction lookupgeneration-txperforms incore.clj, since(as-of "Generation V")is a site-only shorthand(not= ?before ?now)to(< ?before ?now)— verified via REPL that every attack/defense change in this dataset since Generation V is an increase, sonot=was accidentally correct but imprecisesinceas "looks only at what came after" rather than "opposite ofas-of", since it isn't a full complement:stat/specialstays in the schema: Datomic schema only grows, an attribute can be stopped but not deletedVerification
app.core/run-qto confirm the attack/defense stat claim rather than trusting the ticket's wordingclojure -X:test: 32 tests, 493 assertions, 0 failuresCloses #24
🤖 Generated with Claude Code