Repository navigation
Fix hard-coded facts, spelling, and terminology drift (COR-19) - #51
Merged
Merged
Conversation
- Replace text-only numbers that a query could supply with :ui/value: Charizard's base stat total in rules.edn, the speed>100 count in predicates.edn's try-tip, and the legendary Pokemon list in negation.edn (now a runnable query instead of a hard-coded name list). - Remove the hard-coded "15 types" claim in time-travel.edn, which also spoiled the query right below it. - Standardize spelling on "Pokemon" (index.edn had the only remaining "Pokémon" occurrences). - Fix malformed "cardinality/many" to the real keyword ":db.cardinality/many" (negation.edn) or "cardinality-many" as prose (cardinality-many.edn). - Use Datomic's own term "data pattern" instead of "pattern clause" (negation.edn). - Standardize "entity ID" to lowercase "entity id" in querying.edn, matching every other chapter. - Fix padded predicate spacing in predicates.edn's code sample. - De-duplicate try-tips: or-clauses.edn no longer repeats the same "Electric" suggestion twice, and cardinality-many.edn no longer repeats the :pokemon/type schema already shown in modeling-data.edn (now just cross-references it). Closes #32 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Global consistency sweep addressing issue #32 (COR-19): hard-coded facts that a query could supply, inconsistent spelling/terminology, and duplicated content across chapters.
:ui/value: Charizard's base stat total (rules.edn), the speed>100 count in a try-tip (predicates.edn). The hard-coded legendary Pokemon name list innegation.ednis now a runnable query instead (:ui/valueonly handles scalars, not name lists).time-travel.edn, which also gave away the answer to the question asked two sentences later.index.ednhad the only remaining "Pokémon" occurrences.cardinality/manyisn't a real keyword: fixed to:db.cardinality/manyinnegation.edn, and to prose "cardinality-many" incardinality-many.edn.negation.edn; "entity ID" → lowercase "entity id" inquerying.edn, matching every other chapter.[( > ?speed 100 )]→[(> ?speed 100)]inpredicates.edn.or-clauses.edn's try-tip no longer repeats the same "add a third branch for Electric" suggestion twice;cardinality-many.ednno longer repeats the full:pokemon/typeschema already shown inmodeling-data.edn(the existing cross-reference link covers it).All numeric claims were verified against the live dataset via the REPL before wrapping them in
:ui/value(Charizard's total = 534, speed>100 count = 17, matching the ticket's own arithmetic check).Does not touch anything from #39 (still open/unmerged per request) —
src/app/db.clj, thefriendsdataset, and "super-effective" naming were left untouched.Closes #32
Test plan
clojure -X:test— 32 tests, 503 assertions, 0 failures, 0 errors🤖 Generated with Claude Code