Skip to content

feat(web): in-place Cursor variant drill-down in model picker#947

Open
heavygee wants to merge 1 commit into
tiann:mainfrom
heavygee:feat/cursor-picker-ios-nested
Open

feat(web): in-place Cursor variant drill-down in model picker#947
heavygee wants to merge 1 commit into
tiann:mainfrom
heavygee:feat/cursor-picker-ios-nested

Conversation

@heavygee

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the Cursor model settings popover open after picking a multi-variant base model, then drill down in-place to variants instead of forcing a second reopen.
  • Apply and preselect the default variant immediately on base pick, and sort variant rows with default first.
  • Add a back affordance (← Models) to return to the full model list without dismissing, while variant pick still dismisses.

Why

Users selecting non-default Cursor models are in a minority power-user path. Requiring a second picker open to choose variants is slow and easy to miss on mobile; this change makes base -> variant selection a single continuous flow.

Scope

  • Cursor picker UX only.
  • No backend/schema changes.
  • Includes tests for default-variant mapping and SessionChat model-change behavior.

Test plan

  • bun typecheck
  • cd web && bunx vitest run src/lib/cursorVariantPicker.test.ts src/lib/cursorModelOptions.test.ts src/lib/sessionChatCursorModel.test.ts
  • Dogfood in driver soup on live Cursor sessions (base pick keeps popover open, variant pick closes, default variant first)

Closes #48

Made with Cursor

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings
None.

Summary
Review mode: initial
No issues found in the latest diff. Residual risk: I could not run the Bun typecheck/tests in this runner because bun is not available in PATH, so CI should remain the source of truth for the interaction tests and strict TS coverage.

Testing

  • git diff --check
  • Not run: bun typecheck (bun: command not found)

HAPI Bot

Rebased onto upstream/main: iOS-style nested picker keeps overlay open on
multi-variant base pick, applies default variant immediately, dismisses on
variant selection; preserves upstream Pi model panels and Codex Fast mode.

Co-authored-by: Cursor <cursoragent@cursor.com>
@heavygee heavygee force-pushed the feat/cursor-picker-ios-nested branch from e9b693c to fb46f14 Compare June 18, 2026 16:31

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings
None.

Questions
None.

Summary
Review mode: follow-up after new commits
No issues found in the latest full PR diff. Residual risk: I could not run Bun-based typecheck/tests in this runner because bun is not available in PATH; CI should remain the source of truth for strict TS and interaction coverage.

Testing

  • git diff --check origin/main...HEAD
  • Not run (automation): bun typecheck, bun run test (bun not available in PATH)

HAPI Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This is a test issue

1 participant