feat(web): in-place Cursor variant drill-down in model picker#947
Open
heavygee wants to merge 1 commit into
Open
feat(web): in-place Cursor variant drill-down in model picker#947heavygee wants to merge 1 commit into
heavygee wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Findings
None.
Summary
Review mode: initial
No issues found in the latest diff. Residual risk: I could not run the Bun typecheck/tests in this runner because bun is not available in PATH, so CI should remain the source of truth for the interaction tests and strict TS coverage.
Testing
git diff --check- Not run:
bun typecheck(bun: command not found)
HAPI Bot
Rebased onto upstream/main: iOS-style nested picker keeps overlay open on multi-variant base pick, applies default variant immediately, dismisses on variant selection; preserves upstream Pi model panels and Codex Fast mode. Co-authored-by: Cursor <cursoragent@cursor.com>
e9b693c to
fb46f14
Compare
There was a problem hiding this comment.
Findings
None.
Questions
None.
Summary
Review mode: follow-up after new commits
No issues found in the latest full PR diff. Residual risk: I could not run Bun-based typecheck/tests in this runner because bun is not available in PATH; CI should remain the source of truth for strict TS and interaction coverage.
Testing
git diff --check origin/main...HEAD- Not run (automation):
bun typecheck,bun run test(bunnot available in PATH)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
← Models) to return to the full model list without dismissing, while variant pick still dismisses.Why
Users selecting non-default Cursor models are in a minority power-user path. Requiring a second picker open to choose variants is slow and easy to miss on mobile; this change makes base -> variant selection a single continuous flow.
Scope
Test plan
bun typecheckcd web && bunx vitest run src/lib/cursorVariantPicker.test.ts src/lib/cursorModelOptions.test.ts src/lib/sessionChatCursorModel.test.tsCloses #48
Made with Cursor