fix(web): exit scratchlist mode after successful promote-to-queue send#960
Open
heavygee wants to merge 1 commit into
Open
fix(web): exit scratchlist mode after successful promote-to-queue send#960heavygee wants to merge 1 commit into
heavygee wants to merge 1 commit into
Conversation
…ann#959) After Send to queue accepts, call onExitScratchlistMode so the operator can continue normal chat. Rejected sends keep mode on. Unit + Playwright smoke coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
- No findings.
Summary
- Review mode: initial
- Reviewed the full latest diff for scratchlist queue promotion behavior, unit coverage, and the isolated Playwright fixture. No Blocker/Major/Minor findings found in added or modified lines.
- Residual risk: tests could not be executed in this environment because
bunis unavailable, so this pass is static review plus coverage inspection.
Testing
- Not run (automation;
bununavailable in runner).
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After Send to queue from the scratchlist drawer, scratchlist mode stayed enabled so the next composer send went back into the scratchlist instead of the live agent chat. Promote-to-composer already exited mode (PR #798); promote-to-queue intentionally did not.
This change calls
onExitScratchlistMode()whenonSendreturns true fromhandlePromoteToQueue. Rejected sends keep mode and the entry.Test plan
web:SessionChat.exit-mode.test.tsx(4 tests) — success exits mode; rejection keeps mode; promote-to-composer unchangede2e/scratchlist-exit-after-queue.spec.ts(2 tests) via isolated fixture:3006— Send to queue drops scratchlist mode; normal follow-up chat worksIssues
Fixes #959