Skip to content

fix(json): remove artificial arg limit on JSONArray [CLAUDE] #7559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxa-jonathan-hallee wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix(json): remove artificial arg limit on JSONArray [CLAUDE] #7559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlglot/expressions/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class JSONArray(Expression, Func):
"return_type": False,
"strict": False,
}
is_var_len_args = True


class JSONArrayAgg(Expression, AggFunc):
Expand Down
7 changes: 7 additions & 0 deletions tests/dialects/test_duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,13 @@ def test_duckdb(self):
"snowflake": "SELECT TO_VARIANT(ARRAY_CONSTRUCT())",
},
)
self.validate_all(
"SELECT JSON_ARRAY('a', 'b', 'c', 'd', 'e')",
write={
"duckdb": "SELECT JSON_ARRAY('a', 'b', 'c', 'd', 'e')",
"snowflake": "SELECT TO_VARIANT(ARRAY_CONSTRUCT('a', 'b', 'c', 'd', 'e'))",
},
)
self.validate_identity(
"SELECT col FROM t WHERE JSON_EXTRACT_STRING(col, '$.id') NOT IN ('b')",
"SELECT col FROM t WHERE NOT (col ->> '$.id') IN ('b')",
Expand Down
Loading