PM-5265: Add awards see less toggle#1921
Open
jmgasper wants to merge 38 commits into
Open
Conversation
…M-5203_approval-phase-ai-only
…M-5203_approval-phase-ai-only
…e-ai-only PM-5203 approval phase ai only
Expose marathon compiler issues
…e-ai-only PM-5203 approval phase ai only
What was broken Design two-round schedule edits recalculated in the editor, but saving the challenge could send phase updates without the persisted challenge phase ids. The saved challenge then returned with the default two-round timeline instead of the edited schedule. Root cause The work app converted schedule phases through two serializers before PATCHing the challenge. Both serializers kept the phase definition id but dropped the persisted challenge phase id that the backend can use to update the exact existing phase rows. What was changed Preserved challenge phase ids when converting form phases to the challenge payload and when serializing phases for the challenge PATCH request. Any added/updated tests Updated schedule serialization tests to verify phase ids are retained while existing duration and scheduled date behavior is preserved.
PM-5282: Preserve schedule phase ids on update
What was broken Add Reviewer could use the first default reviewer row even when that row belonged to a phase that was not present in the current one-round Design challenge. Root cause Dev default reviewer metadata includes checkpoint phase defaults ahead of the single-round review defaults. The UI did not filter defaults against the active challenge phases or existing human reviewer rows before appending a new reviewer card. What was changed The human review tab now selects the next member-reviewer default whose phase is selectable for the current challenge, preferring unassigned phases and falling back only to selectable defaults. Any added/updated tests Added a HumanReviewTab regression test that reproduces the one-round Design ordering and verifies Add Reviewer selects the Review phase and scorecard instead of an unrelated checkpoint default.
PM-5243: Add reviewer with next valid default phase
What was broken The profile awards preview could expand from the default four-award view to show more awards, but there was no control to collapse the section back to the default view. Root cause The awards section only exposed the more-badges action for the collapsed state and did not render a matching collapse action after expansion. What was changed Updated CommunityAwards to load enough badge rows for inline expansion, show four badges by default, toggle the control between the more-badges label and See less, and reset the collapsed state when the viewed profile changes. Updated the awards styling to use the compact badge grid and more/less link shown in the profile awards section. Any added/updated tests Added CommunityAwards coverage for badge tooltip rendering and for expanding awards and collapsing them back to the default view.
# Conflicts: # src/apps/profiles/src/member-profile/community-awards/CommunityAwards.spec.tsx # src/apps/profiles/src/member-profile/community-awards/CommunityAwards.tsx # src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/HumanReviewTab.spec.tsx # src/apps/work/src/pages/challenges/ChallengeEditorPage/components/ReviewersField/HumanReviewTab.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The profile awards preview could expand from the default four-award view to show more awards, but there was no control to collapse the section back to the default view.
Root cause
The awards section only exposed the more-badges action for the collapsed state and did not render a matching collapse action after expansion.
What was changed
Updated CommunityAwards to load enough badge rows for inline expansion, show four badges by default, toggle the control between the more-badges label and See less, and reset the collapsed state when the viewed profile changes.
Updated the awards styling to use the compact badge grid and more/less link shown in the profile awards section.
Any added/updated tests
Added CommunityAwards coverage for badge tooltip rendering and for expanding awards and collapsing them back to the default view.
Validation run: