PM-5221: show Data Science Challenge stats#1940
Merged
Merged
Conversation
…l-reviewers Require manual reviewers
…ts, and a fix for PM-5328
PM 5120 - Cleanup Talent Search from Platform-UI
What was broken The previous API fixes persisted and returned Data Science Challenge stats under DATA_SCIENCE.Challenge, but the profile achievements UI only considered DATA_SCIENCE.MARATHON_MATCH for the Data Science track. After a Data Science Challenge completed, the main profile rating could increase while the Member Stats card and drill-down path still showed the older Marathon Match rating/history. Root cause (if identifiable) The active-track mapper hardcoded Data Science to Marathon Match and SRM only. It ignored the Challenge subtrack key now produced by member-api for Data Science Challenge ratings/history. What was changed Added DATA_SCIENCE.Challenge to the profile stats and history models, included it as an active Data Science subtrack, and changed the Data Science summary card to use the strongest visible Data Science subtrack rating instead of always using Marathon Match. Any added/updated tests Added getActiveTracks coverage for a member with Data Science Challenge and Marathon Match stats to verify the Challenge subtrack is included and its newer rating drives the Data Science summary.
# Conflicts: # src/apps/profiles/src/hooks/useFetchActiveTracks.tsx # src/libs/core/lib/profile/user-stats.model.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The previous API fixes persisted and returned Data Science Challenge stats under DATA_SCIENCE.Challenge, but the profile achievements UI only considered DATA_SCIENCE.MARATHON_MATCH for the Data Science track. After a Data Science Challenge completed, the main profile rating could increase while the Member Stats card and drill-down path still showed the older Marathon Match rating/history.
Root cause (if identifiable)
The active-track mapper hardcoded Data Science to Marathon Match and SRM only. It ignored the Challenge subtrack key now produced by member-api for Data Science Challenge ratings/history.
What was changed
Added DATA_SCIENCE.Challenge to the profile stats and history models, included it as an active Data Science subtrack, and changed the Data Science summary card to use the strongest visible Data Science subtrack rating instead of always using Marathon Match.
Any added/updated tests
Added getActiveTracks coverage for a member with Data Science Challenge and Marathon Match stats to verify the Challenge subtrack is included and its newer rating drives the Data Science summary.